Re: [Libreoffice] [PUSHED] Adding and Removing Color Charts

On 25-03-11 07:20, Michael Meeks wrote:
> Hi Rob,
>
> On Thu, 2011-03-24 at 21:37 +0100, Rob Snelders wrote:
> > I have created a patch that enables users to add and remove Color Charts.
>
>         Oooh, nice :-) I had a play with Tools->Options->Chart colors, and it
> seems to work very nicely - I tried the corner cases of no colors, and
> so on and they seem to work.
>
>         Adding black colors is a bit nasty though :-) I wonder if we could
> clone the previously selected color instead (?)

The only problem is that when you select a color it will set that color 
for the selected item. So you change the color-chart you already had.

>         Also, I guess perhaps we should dynamically renumber / rename the
> existing colors if we remove colors in the middle (?) although its not
> perhaps very cricical (thoughts on that ?).

I also think that is needed. Also it will be needed to select the added 
item when you add an item, and select the next item when you delete an 
item. I'll try to work on that next week.

>         Anyhow - I've pushed it; can you confirm it is licensed
> LGPLv3+/MPL ? and was this a result of the Netherlands hack-fest ? :-)
> it should show up in 3.4.

Yes, this is a result of that hack-fest. It was fun and enlightning to 
work there, I there will be another one, there where plans.
>         ATB,
>
>                 Michael.

Greetings,
Rob Snelders