Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString

On Tue, 2011-03-22 at 08:11 +0100, David Tardon wrote:
> On Tue, Mar 15, 2011 at 01:10:58PM +0100, Xisco Faulí wrote:
> > Hello,
> >
> >
> > It's the first time I do it so I searched for previous commits  in order to
> > get a referent. i couldn't find any example for String.AssignAscii so I
> > replace it with OUStringBuffer.appendAscii.
>
> Yeah, that is good.

You might have missed my mail on the other variant of this patch, i.e.

"
there's a little bug in the new Dbg_SbxDataType2String impl, the
old one had...

String aRet( RTL_CONSTASCII_USTRINGPARAM("Unknown Sbx-Type!") );
...
aRet = something
...
return aRet;

while the new one has...

::rtl::OUStringBuffer aRet;
aRet.appendAscii("Unknown Sbx-Type!");
...
aRet.appendAscii("something");

i.e. now its "Unknown Sbx-Type!something" instead of "something". so
that one needs fixing.
"

among others

C.