Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString

David Tardon <dtardon -AT- redhat.com>
Tue, 22 Mar 2011 08:11:16 +0100

On Tue, Mar 15, 2011 at 01:10:58PM +0100, Xisco Faulí wrote:

Hello,


It's the first time I do it so I searched for previous commits  in order to
get a referent. i couldn't find any example for String.AssignAscii so I
replace it with OUStringBuffer.appendAscii.


Yeah, that is good. I only added RTL_CONSTASCII_STRINGPARAM around
string literals. I also replaced occurrences of
aStr.equals(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("foo")))
by
aStr.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM("foo"))
(similarly for equalsIgnoreAsciiCase and equalsIgnoreAsciiCaseAsciiL)
and aStr.getLen() in conditions by !aStr.isEmpty().

D.

Context

[Libreoffice] [PATCH] remove String with OUString · Xisco Faulí
- Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString · David Tardon
  - Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString · Caolán McNamara
    - Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString · Caolán McNamara
      - Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString · Caolán McNamara
      - Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString · Noel Power
        
        Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString · Caolán McNamara
        
        Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString · Noel Power
        
        Re: [Libreoffice] [PATCH] [PUSHED] remove String with OUString · Bjoern Michaelsen

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.