[Libreoffice] [PATCH] Use GDK_HAND2 mouse cursor instead of GDK_HAND1

Hi,

Here is a patch to make LibeOffice use a more commonly-used mouse cursor in GTK.

Currently LibreOffice uses GDK_HAND1 for POINTER_REFHAND and GDK_HAND2
for POINTER_HAND.
As a result, LibreOffice uses GDK_HAND1 for hyperlinks, while many
GTK2 applications use GDK_HAND2.
# See attached png images.

Since there is not much difference between GDK_HAND1 and GDK_HAND2 and
GDK_HAND1 is not commonly used, we should use GDK_HAND2 for both
POINTER_REFHAND and POINTER_HAND.
# GDK_HAND1 means "a right-pointing hand" and GDK_HAND2 means "a
left-pointing hand"
# http://library.gnome.org/devel/gdk/stable/gdk-Cursors.html

This patch is under LGPLv3+/MPL.

Cheers,
--
Kurosawa Takeshi <taken.spc@gmail.com>

From 1e0faa2c0190a47d3bbd7d412bfe8d06518f0330 Mon Sep 17 00:00:00 2001
From: Kurosawa Takeshi <taken.spc@gmail.com>
Date: Fri, 11 Feb 2011 20:08:38 +0900
Subject: [PATCH] Use GDK_HAND2 mouse cursor instead of GDK_HAND1

LibreOffice uses GDK_HAND1 for POINTER_REFHAND and GDK_HAND2 for POINTER_HAND.
However there is not much difference between GDK_HAND1 and GDK_HAND2.
GDK_HAND1 means "a right-pointing hand" and GDK_HAND2 means "a left-pointing hand".

Since GDK_HAND2 is much more popular and some cursor themes don't contain cursor file for 
GDK_HAND1, we should use GDK_HAND2 for both POINTER_REFHAND and POINTER_HAND.
---
 vcl/unx/gtk/app/gtkdata.cxx |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/vcl/unx/gtk/app/gtkdata.cxx b/vcl/unx/gtk/app/gtkdata.cxx
index 40c2aed..90fabe8 100644
--- a/vcl/unx/gtk/app/gtkdata.cxx
+++ b/vcl/unx/gtk/app/gtkdata.cxx
@@ -391,7 +391,7 @@ GdkCursor *GtkSalDisplay::getCursor( PointerStyle ePointerStyle )
             MAP_BUILTIN( POINTER_HSIZEBAR, GDK_SB_H_DOUBLE_ARROW );
             MAP_BUILTIN( POINTER_VSIZEBAR, GDK_SB_V_DOUBLE_ARROW );
 
-            MAP_BUILTIN( POINTER_REFHAND, GDK_HAND1 );
+            MAP_BUILTIN( POINTER_REFHAND, GDK_HAND2 );
             MAP_BUILTIN( POINTER_HAND, GDK_HAND2 );
             MAP_BUILTIN( POINTER_PEN, GDK_PENCIL );
 
-- 
1.7.1

Attachment: GDK_HAND1_in_lo.png
Description: PNG image

Attachment: GDK_HAND2_in_gimp.png
Description: PNG image