Hi
So - if we drop that; where are we at ? :-) If we can load the file, edit it, and hit 'save as' (without having to click the "get me out of ! #$#$%#%ing read-only-mode" button)
Was pretty easy. As you asked, here patch (0001) for making the StarWriter file format input only
write specific ripping junk out of the binfilter code :-)
Then, as first step, I had to change in binfilter migrate, so that for filter without EXPORT flag, the write storage is not called any more. (see patch 0002). Then, the following patches (0003 - 0008) are for ripping out the code in binfilter/bf_sw. (this is not finished...) I do it class by class, since there are sometimes dependencies, and I like leaving between 2 commits a usable state of the stack. Further, this is easier for me to test that I did not break anyhing - hope so at least. Maybe I am too cautious, but I got by me twice a state where I couldn't read anymore a StarWriter 5.0 file. So I prefer this approach. If you give me a Ok, I will push it to master and continue based on this approch: filter by filter (and class by class) ripping out, and then the "generic" binfilter module. Best regards Pierre-André ps1: in docnode/sw_nodes.cxx I took out a part that seems really for debug... "c:\ " pathes with linux... ps2: actually, some functions are / were defined & called within binfilter (no call-catcher), but could not be reached any more starting from the gui-save as trigger. So I wonder if this is a result of the kind of uno-magical-binding (which I really dislike and not really understand, or the other way around), or if I missed something.
Attachment:
0001-Star-Writer-file-format-not-EXPORT-anymore.patch
Description: application/mbox
Attachment:
0002-not-using-Write-function-on-loading-anymore-for-binf.patch
Description: application/mbox
Attachment:
0003-deletion-of-StgWriter-Write-and-its-dependancies.patch
Description: application/mbox
Attachment:
0004-deletion-of-Sw3Io-Save-and-Sw3Io-SaveAs-in-binfilter.patch
Description: application/mbox
Attachment:
0005-class-Sw3Writer-in-binfilter-deleted.patch
Description: application/mbox
Attachment:
0006-delete-binfilter-bf_sw-SwXMLWriter-class.patch
Description: application/mbox
Attachment:
0007-delete-in-binfilter-bf_sw-class-StgWriter.patch
Description: application/mbox
Attachment:
0008-delete-in-binfilter-bf_sw-class-SwWriter.patch
Description: application/mbox