Re: [Libreoffice] [REVIEW] unopkg --suppress-license

Hello Kohei, others,

I have created a bug report for this (fdo#32840)... and fixed it in
master branch.

Could someone review it for a possible integration in 3.3 ?

Regards,

--
Cedric

On Tue, 2011-01-04 at 16:09 -0500, Kohei Yoshida wrote:
> On Tue, 2011-01-04 at 22:04 +0100, Cedric Bosdonnat wrote:
> > Hello hackers,
> >
> > I would like to make the --suppress-license option of unopkg skip the
> > license in all cases instead of depending on what is in the extension's
> > description.xml //simple-license[@suppress-if-required].
> >
> > http://wiki.services.openoffice.org/wiki/Documentation/DevGuide/Extensions/Description_of_XML_Elements#Element_.2Fdescription.2Fregistration.2Fsimple-license
> >
> > According to this wiki page, this feature has been introduced in OOo
> > 3.3... which isn't released yet.
> >
> > Do you have any strong opinion against that? I would need this kind of
> > unconditional skip to run unopkg from within ooeclipse... where people
> > should develop their extensions and know the license ;)
>
> IMO the principle of lease surprise dictates that, when given
> --suppress-license, it should suppress license unconditionally no matter
> what some file in undisclosed location has in it.
>
> So, I'm with you on that.
>
> Kohei

-- 
Cédric Bosdonnat
LibreOffice hacker
http://documentfoundation.org
OOo Eclipse Integration developer
http://cedric.bosdonnat.free.fr