Re: [Libreoffice] comments translated in writer\sw\source\core\edit\edfmt.cxx

On Tue, Dec 28, 2010 at 5:25 AM, TentleXS <TentleXS@web.de> wrote:
> Am 27.12.2010 20:12, schrieb Octavio Alvarez:
> > On Mon, 27 Dec 2010 10:49:19 -0800, TentleXS <TentleXS@web.de> wrote:
> >
> > > Hallo @all,
> > > my name is Pascal and I would like to contribute the following
> > > translated code comments in "writer\sw\source\core\edit\edfmt.cxx". My
> > > native language is german so I hope it's OK that I did the translation.
> >
> > Do you take requests? :-) I've been trying to work with these files, but
> > I can't get the sense out of them. I'm putting my hope on the comments
> > which are currently in German.
> >
> > sw/source/core/crsr/callnk.cxx
> > sw/source/core/crsr/viscrs.cxx
> >
> > > I am learning the workflow for contributing, so please excuse me if I
> > > did something wrong. I am glad if you decide to point me to resources
> > > where I can read up on how to contribute more effectively. I am not sure
> > > if I should mention that this code and its comments is contributed under
> > > LGPLv3+ / MPL ... because I just changed the comments ... but of course
> > > it is. (It's just for new code/code-changes, right?)
> >
> > Also, I would send it as a git patch so the committer can keep your
> > authorship information. Otherwise, if someone picks your diff up he will
> > need to apply your diff and create the commit himself and your
> > authorship information gets lost.
> > _______________________________________________
> > LibreOffice mailing list
> > LibreOffice@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
> I hope I did this right.
> This should be a patch file for
> writer/sw/source/core/edit/edfmt.cxx
> writer/sw/source/core/crsr/callnk.cxx

you can combine change to multiple sources files together, as long as
they belong to the same git repository.

> Do I have to name the file differently?

If you use git format-patch the default name will be based on the
commit message, which hopefully will be distinctive enough
if not, make sure that the title in your mailing list post in new and
differents from previous patch submission
that will help us not to miss any.
When a patch is pushed to the git repo, we typically send a reply to
the ML with [Pushed] added to the title. Using the same title for
two or more patch submission, increase the chance that a patch being
accidentally dropped.

Norbert

> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice