Re: [Libreoffice] comments translated in writer\sw\source\core\edit\edfmt.cxx

On Mon, Dec 27, 2010 at 12:49 PM, TentleXS <TentleXS@web.de> wrote:
> Hallo @all,
> my name is Pascal and I would like to contribute the following
> translated code comments in "writer\sw\source\core\edit\edfmt.cxx". My
> native language is german so I hope it's OK that I did the translation.

Hi Pascal,

Welcome to LibreOffice dev.
A translation by a native german speaker is mst welcome.

> I am learning the workflow for contributing, so please excuse me if I
> did something wrong.

You did it right.
to make it perfect you could do this:

http://wiki.documentfoundation.org/Development#Preparing_patches
The reason for this is that git format-patch contain all the
authorship information as you want them to be.
It is also nice to suffix the patch file name with the repository
name, so it is a no-brainer for the commiter to know on which repo
this patch apply (for instance sw is in the 'writer' repo, so the
patch filename should look something like 0001-xxxxxxx.writer.patch)


> I am glad if you decide to point me to resources
> where I can read up on how to contribute more effectively. I am not sure
> if I should mention that this code and its comments is contributed under
> LGPLv3+ / MPL ... because I just changed the comments ... but of course
> it is. (It 's just for new code/code-changes, right?)
>
> A little bit about me:
> I am a software developer working with Microsoft Dynamics NAV and
> C#/.NET for almost nine years now.

My condolences.

> I do understand C/C++ and have done
> some small projects some years ago using these languages, but I feel
> that I have to warm up to using them again :). This is my first
> contribution to a libre software project and I hope it will not be the
> last one. I know that I have much to learn and I am excited to do so.

we all have much to learn... that's a big part of the fun :-)

> It would be great to receive at least a reply like: "This was OK." or
> "You should just have attached the file." or something like that. :)

If you would please send the name under which to commit your submission ?
I could use 'Pascal <TentleXS@web.de>', but I'd rather be sure that is
what you really want (can't change it after the fact)

Norbert

> Here is the diff (also to be found in the attached file):
>
> <diff>
> diff --git a/sw/source/core/edit/edfmt.cxx b/sw/source/core/edit/edfmt.cxx
> index 016fa4d..1ec3814 100644
> --- a/sw/source/core/edit/edfmt.cxx
> +++ b/sw/source/core/edit/edfmt.cxx
> @@ -39,7 +39,7 @@
>  #include <fchrfmt.hxx>
>  #include <frmfmt.hxx>
>  #include <charfmt.hxx>
> -#include "ndtxt.hxx"    // Fuer GetXXXFmt
> +#include "ndtxt.hxx"    // for GetXXXFmt
>  #include "hints.hxx"
>
>  /*************************************
> @@ -93,7 +93,7 @@ void SwEditShell::FillByEx(SwCharFmt* pCharFmt, BOOL
> bReset)
>         {
>             const SwPosition* pPtPos = pPam->GetPoint();
>             const SwPosition* pMkPos = pPam->GetMark();
> -            if( pPtPos->nNode == pMkPos->nNode )        // im selben Node ?
> +            if( pPtPos->nNode == pMkPos->nNode )        // in the same
> node?
>             {
>                 nStt = pPtPos->nContent.GetIndex();
>                 if( nStt < pMkPos->nContent.GetIndex() )
> @@ -155,7 +155,7 @@ SwCharFmt* SwEditShell::MakeCharFmt( const String&
> rName,
>  }
>
>  //----------------------------------
> -// inlines im Product
> +// inlines in product
>
>
>  SwTxtFmtColl* SwEditShell::GetTxtCollFromPool( USHORT nId )
> @@ -164,7 +164,7 @@ SwTxtFmtColl* SwEditShell::GetTxtCollFromPool( USHORT
> nId )
>  }
>
>
> -    // return das geforderte automatische  Format - Basis-Klasse !
> +    // return the demanded automatic format - base-class !
>  SwFmt* SwEditShell::GetFmtFromPool( USHORT nId )
>  {
>     return GetDoc()->GetFmtFromPool( nId );
> </diff>
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice