Date: prev next · Thread: first prev next last
2010 Archives by date, by thread · List index


Hi Radek,

On Wed, 22 Dec 2010 12:02:57 +0100, Radek Doulik <rodo@novell.com> wrote:
Still loitering on EasyHack 3.7, I encountered dead codes as attached.
They seems safely removable because if -psn given, the call of
InterpretCommandLineParameter() will catch it and return sal_True, so
the lines in question will be never passed through.
It looks odd noneththeless. Any thought?

couldn't be then typo in InterpretCommandLineParameter? maybe it should
#ifndef it in case of MACOSX, so that the other part makes sense? I
don't have any OOo CVS tree at hand now, but Thorsten might know.
The lines surrounded by #ifdef/#endif in InterpretCommandLineParameter()
are indeed only for Mac OS X, according to the original issue:
http://qa.openoffice.org/issues/show_bug.cgi?id=84053
You can browse corresponding OOo codes at:
http://svn.services.openoffice.org/opengrok/xref/Current%20(trunk)/desktop/source/app/cmdlineargs.cxx

Cheers,
-- Takeshi Abe

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.