Re: [Libreoffice] [PATCH] remove dead codes never passed through even in case of MACOSX

Hi Takeshi,

On Wed, 2010-12-22 at 17:21 +0900, Takeshi Abe wrote:
> Hi,
>
> Still loitering on EasyHack 3.7, I encountered dead codes as attached.
> They seems safely removable because if -psn given, the call of
> InterpretCommandLineParameter() will catch it and return sal_True, so
> the lines in question will be never passed through.
> It looks odd noneththeless. Any thought?

couldn't be then typo in InterpretCommandLineParameter? maybe it should
#ifndef it in case of MACOSX, so that the other part makes sense? I
don't have any OOo CVS tree at hand now, but Thorsten might know.

Cheers
Radek

> Cheers,
> -- Takeshi Abe
> differences between files attachment
> (0001-remove-dead-codes-never-passed-through-even-in-case-.patch)
> > From f06b3e31df80d48a1eb773acfea7563377928dba Mon Sep 17 00:00:00 2001
> From: Takeshi Abe <tabe@fixedpoint.jp>
> Date: Wed, 22 Dec 2010 16:33:34 +0900
> Subject: [PATCH] remove dead codes never passed through even in case of MACOSX
>
> ---
>  desktop/source/app/cmdlineargs.cxx |   20 --------------------
>  1 files changed, 0 insertions(+), 20 deletions(-)
>
> diff --git a/desktop/source/app/cmdlineargs.cxx b/desktop/source/app/cmdlineargs.cxx
> index 97a9fb9..f9ac187 100644
> --- a/desktop/source/app/cmdlineargs.cxx
> +++ b/desktop/source/app/cmdlineargs.cxx
> @@ -280,26 +280,6 @@ void CommandLineArgs::ParseCommandLine_Impl( Supplier& supplier )
>                          bStartEvent     = sal_False;
>                          bDisplaySpec = sal_False;
>                      }
> -
> -                    #ifdef MACOSX
> -                    /* #i84053# ignore -psn on Mac
> -                       Platform dependent #ifdef here is ugly, however this is currently
> -                       the only platform dependent parameter. Should more appear
> -                       we should find a better solution
> -                    */
> -                    else if ( aArg.matchAsciiL(RTL_CONSTASCII_STRINGPARAM("-psn")))
> -                    {
> -                        // finder argument from MacOSX
> -                        bOpenEvent      = sal_False;
> -                           bPrintEvent     = sal_False;
> -                        bForceOpenEvent = sal_False;
> -                        bPrintToEvent   = sal_False;
> -                        bForceNewEvent  = sal_False;
> -                        bViewEvent      = sal_False;
> -                        bStartEvent     = sal_False;
> -                        bDisplaySpec = sal_False;
> -                    }
> -                    #endif
>                      else if ( 
> aArg.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM("-convert-to")))
>                      {
>                          bOpenEvent = sal_False;
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice