[Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

Mattias Johnsson <m.t.johnsson -AT- gmail.com>
Thu, 4 Nov 2010 23:38:51 +1100

After spending a number of hours learning more about unicode than I
ever wanted to know, I've fixed the bug where the word counter in
Writer counts an opening quote mark (unicode symbol 0x201C) as an extra
word.

Turns out that the opening quote lives in unicode block 40, which was
not given an associated script type in breakiteratorImpl.cxx. This
means that its
script type was defaulting to "WEAK" rather than "LATIN", and "WEAK"
is taken as a word break.

Thought I should get in fast and submit this before John LeMoyne
Castle's heroic efforts fix all the word counter problems :-P

Patch attached. It's a very minimal change, so it's probably safe to
push into the 3.3 branch as well as master.

Cheers,
Mattias

Context

[Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word · Mattias Johnsson
- Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word · Mattias Johnsson
  - Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word · Cedric Bosdonnat
    - Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word · Mattias Johnsson
      - Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word · John LeMoyne Castle
        
        Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word · John LeMoyne Castle
        
        Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word · Cedric Bosdonnat
        
        Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word · John LeMoyne Castle
      - Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word · Cedric Bosdonnat
        
        Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word · Mattias Johnsson
        
        Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word · John LeMoyne Castle

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.