Re: [Libreoffice] [PATCH] Fix bug where an opening quote mark is treated as a word

Hi again, 

Well I suggested it so ran a few tests after a full re-build finished.  I
was curious.  I don't think the target should be 'counts exactly like Word'
but certainly a quotation mark shouldn't count as its own word when it is
adjacent to text on either side.  Especially there shouldn't be a difference
between the leading quote and the trailing quote.  

In OOo 3.2 for Linux: 
  --  the para selection results do not match the target = Word behavior 
(OOOo3.2 for/from Ubuntu 10.04) 
  --  the selection of any one quote character gives a count of (W:1, C:1,
Cnos:1) for all of the 12 (+?) quote chars - it generates a word when by
itself but a leading special quote char counts as a separate word when other
non space text is next to it.  The 'word to itself' effect for only (!?!)
leading special quotes is the source of the errors in the section labelled
"THESE ARE WRONG" 

In LibOdev config, aligned with origin/master, before Mattias' UBLOCK patch:
  --  the para selection results match the target = Word behavior given in
the document.   
  --  the selection of any one quote character gives a count of (W:1, C:1,
Cnos:1) for all of the 12 (+?) quote chars - it generates a word when by
itself and does not count as a separate word when other non space text is
next to it.  

In same LibOdev after the 1 line patch was manually merged:
  --  the para selection results match the target = Word behavior given in
the document.   
  --  the selection of any one quote character gives a count of (W:1, C:1,
Cnos:1) for all of the 12 (+?) quote chars - it generates a word when by
itself and does not count as a separate word when other non space text is
next to it.  

In other words, I am not seeing any change with this patch.  Even with rm
-Rf install && make dev-install after the build with the patch.  This lack
of difference could be due to: 
 - me.  Could be something off about my build setup.  Or the Writer setup. 
Or the way I am testing it.
 - a difference in config prep.  I think Mattias is working againt the
stable dev3.3 branch while I am working against dev master.  The leading
quote problem could already be fixed in dev.
 - language difference.  I am testing this with en-US.  The SwScanner is
given a 0 for language which is used in a lookup that I *think* means use
the current language so maybe the results will differ for docs viewed or
made in some other language.  In fact there are multiple reports of Asian
counts being way off in OOo bug tracker so no bet there.  

Dang, I was hoping it would stop counting at least some punctuation as a
word.(period).  Don't know what to say other than test before and after. 

As a separate potential issue: 
In a fresh current dev build with AutoCorrect on for single & double quotes
the Apply While Typing modified them into the selected special symbols
(Tools->AutoCorrect->Localized Options Tab).  But I could not get the
Format->AutoCorrect->Apply to change either the whole doc or a selection. 
Again, this could be /me from user error or from a faulty build, but this
may be another bug: Format->AutoCorrect->Apply not working? for just quotes
or other replacements as well?.   
-- LeMoyne
-- 
View this message in context: 
http://nabble.documentfoundation.org/PATCH-Fix-bug-where-an-opening-quote-mark-is-treated-as-a-word-tp1841260p1846816.html
Sent from the Dev mailing list archive at Nabble.com.