Cedric Bosdonnat wrote (06-07-11 15:13)
On Wed, 2011-07-06 at 14:01 +0200, Cor Nouws wrote:Runs fine for about two hours now... But hey, how would I be able to see a feature in the master, that has not yet been finished and pushed :-)I already pushed a lot of it before sending the email here. My commits are to be considered as a basis for a better work but that doesn't mean you won't see the feature at all ;)
Indeed, can work with it :-) Some comments:1. Could it be possible to change from main to header/footer by single mouse click, in stead of double. (I know the other program uses double click, but looks superfluous to me)
2. Refresh problem when height of header/footer changes. - HeaderFooter_CB_01.png3. grey-tone does not toggle when changing content with Ctrl-PageUp (PageDown for footer), and I can use the cursor here, but not the mouse :-)
- HeaderFooter_CB_03.png4. It was new for me to see (but maybe missed it from what you wrote) that the line only is visible when the header/footer is activated (by double clicking ATM).
Then the visual challenge ;-)5. For the line: I would advice the same color, or something that is close to the text boundaries. Reason: the line is wider, does change width with zooming, and is dashed. I have nothing against the nice blue color, but it's just to much as default within the current UI, IMO.
Page break = = = = = 6. For the hard page break: now it is blue – my advise would be light blue.7. It is not such a problem that the break is partly covered by the new separator, since that only is the case when header/footer is active Problem with the page break though: when spacing of the header/footer is zero, it is not visible (covered by the inner boundary of the header/footer apparently.)
See also - HeaderFooter_CB_03.png Maybe some of the quirks have been solved already in your dev-code. So far this non-expert advise ;-)Maybe Christoph is interested to see some special situations? Pls drop a line later this evening, and maybe I (we) can help.
Cheers, -- - Cor - http://nl.libreoffice.org
Attachment:
HeaderFooter_CB_03.png
Description: PNG image
Attachment:
HeaderFooter_CB_02.png
Description: PNG image
Attachment:
HeaderFooter_CB_01.png
Description: PNG image