Re: [Libreoffice-ux-advise] [Libreoffice] [PATCH] Removes find/replace dialog button from standard toolbar

Hi Sam,

        Ooh - another nice patch that belongs on ux-advise quickly. And - UX
guys, it seems you have someone who cares about UI here ... lets see how
things pan out here.

        Sam - some of these require a little thought by the UX guys, but I
think some other things would be rather less controversial; so - if eg.
we could add a 'match case' check-box to the 'find bar' (mirroring
Firefox's) I'm sure that'd be trivial to get approved/ committed.

        Also UI team - I'd love some more thought into the "find next" "find
previous" icons; and some better artwork there, or even plain text [ we
have lots of horizontal space at this point I think ] - cf. what Firefox
does here. [ oh, I notice there is also a nice wrap-around notification
in firefox there - but perhaps I'm just greedy ]

        Sam - if you need more code pointers to adding funky widgets in there,
happy to help [ best to poke on IRC #libreoffice-dev, irc.freenode.net -
mmeeks ]

        HTH,

                Michael.

On Sat, 2011-06-11 at 07:35 -0700, Samuel Cantrell wrote:
> These patches remove the find/replace dialog button from Calc and
> Writer (per http://wiki.documentfoundation.org/Development/Default_UI_Improvements).
> As we have the new find toolbar, these buttons seem unnecessary.
>
> I should note that these patches don't remove the functionality of the
> buttons, but rather, hide them by default. This allows for a user to
> add them if he so chooses (for example if he doesn't like the find
> toolbar or something).
>
> Thanks!
>
> Samuel Cantrell
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

-- 
 michael.meeks@novell.com  <><, Pseudo Engineer, itinerant idiot

From d6314ef8294769ffc953e75a5e95f16516e6c9f8 Mon Sep 17 00:00:00 2001
From: Jacek Wolszczak <shutdownrunner@gmail.com>
Date: Tue, 10 May 2011 12:18:03 +0200
Subject: [PATCH 3/3] Remove #include <tools/debug.hxx> in writer/sw

---
 sw/inc/PostItMgr.hxx                         |    1 -
 sw/inc/accmap.hxx                            |    1 -
 sw/inc/fldbas.hxx                            |    2 --
 sw/inc/pch/precompiled_sw.hxx                |    1 -
 sw/qa/core/bigpointerarray-new.hxx           |    2 --
 sw/source/core/access/acccontext.cxx         |    1 -
 sw/source/core/access/accmap.cxx             |    2 --
 sw/source/core/access/accportions.cxx        |    1 -
 sw/source/core/access/accselectionhelper.cxx |    1 -
 sw/source/core/doc/SwStyleNameMapper.cxx     |    1 -
 sw/source/core/text/wrong.cxx                |    1 -
 sw/source/core/tox/toxhlp.cxx                |    1 -
 sw/source/core/unocore/swunohelper.cxx       |    1 -
 sw/source/core/unocore/unoidx.cxx            |    1 -
 sw/source/core/unocore/unoprnms.cxx          |    1 -
 sw/source/core/unocore/unoredlines.cxx       |    1 -
 sw/source/core/view/printdata.cxx            |    1 -
 sw/source/core/view/vprint.cxx               |    1 -
 sw/source/filter/html/parcss1.cxx            |    1 -
 sw/source/filter/writer/wrtswtbl.cxx         |    1 -
 sw/source/filter/ww1/w1class.hxx             |    1 -
 sw/source/filter/ww8/hash_wrap.hxx           |    1 -
 sw/source/filter/ww8/needed_cast.hxx         |    1 -
 sw/source/filter/ww8/sortedarray.hxx         |    1 -
 sw/source/filter/ww8/styles.cxx              |    1 -
 sw/source/filter/ww8/ww8scan.cxx             |    1 -
 sw/source/filter/xml/xmlbrsh.cxx             |    1 -
 sw/source/filter/xml/xmlitem.cxx             |    1 -
 28 files changed, 0 insertions(+), 31 deletions(-)

diff --git a/sw/inc/PostItMgr.hxx b/sw/inc/PostItMgr.hxx
index 905dc4f..e459581 100644
--- a/sw/inc/PostItMgr.hxx
+++ b/sw/inc/PostItMgr.hxx
@@ -34,7 +34,6 @@
 #include <editeng/outlobj.hxx>
 #include <tools/string.hxx>
 #include <tools/link.hxx>
-#include <tools/debug.hxx>
 #include <swrect.hxx>
 #include <unotools/configitem.hxx>
 #include <unotools/options.hxx>
diff --git a/sw/inc/accmap.hxx b/sw/inc/accmap.hxx
index 0bffbcb..315ba24 100644
--- a/sw/inc/accmap.hxx
+++ b/sw/inc/accmap.hxx
@@ -34,7 +34,6 @@
 #include <osl/mutex.hxx>
 #include <svx/IAccessibleViewForwarder.hxx>
 #include <svx/IAccessibleParent.hxx>
-#include <tools/debug.hxx>
 #include <tools/fract.hxx>
 
 #include <vector>
diff --git a/sw/inc/fldbas.hxx b/sw/inc/fldbas.hxx
index 23ce783..baa1bc0 100644
--- a/sw/inc/fldbas.hxx
+++ b/sw/inc/fldbas.hxx
@@ -29,7 +29,6 @@
 #define SW_FLDBAS_HXX
 
 #include <i18npool/lang.h>
-#include <tools/debug.hxx>
 #include <tools/string.hxx>
 #include "swdllapi.h"
 #include <calbck.hxx>
@@ -237,7 +236,6 @@ String  FormatNumber(sal_uInt16 nNum, sal_uInt32 nFormat);
 // Instances of SwFields and those derived from it occur 0 to n times.
 // For each class there is one instance of the associated type class.
 // Base class of all field types is SwFieldType.
-DBG_NAMEEX(SwFieldType)
 
 class SW_DLLPUBLIC SwFieldType : public SwModify
 {
diff --git a/sw/inc/pch/precompiled_sw.hxx b/sw/inc/pch/precompiled_sw.hxx
index 63fef81..a976f6d 100644
--- a/sw/inc/pch/precompiled_sw.hxx
+++ b/sw/inc/pch/precompiled_sw.hxx
@@ -844,7 +844,6 @@
 #include "tools/color.hxx"
 #include "tools/date.hxx"
 #include "tools/datetime.hxx"
-#include "tools/debug.hxx"
 #include "tools/errcode.hxx"
 #include "tools/errinf.hxx"
 #include "tools/fract.hxx"
diff --git a/sw/qa/core/bigpointerarray-new.hxx b/sw/qa/core/bigpointerarray-new.hxx
index 0c835a0..b48a815 100644
--- a/sw/qa/core/bigpointerarray-new.hxx
+++ b/sw/qa/core/bigpointerarray-new.hxx
@@ -30,8 +30,6 @@
 #define _BPARR_HXX
 
 #include <tools/solar.h>
-#include <tools/debug.hxx>
-
 #include <deque>
 
 class BigPtrArray;
diff --git a/sw/source/core/access/acccontext.cxx b/sw/source/core/access/acccontext.cxx
index 6f7eb82..bbb07c6 100644
--- a/sw/source/core/access/acccontext.cxx
+++ b/sw/source/core/access/acccontext.cxx
@@ -28,7 +28,6 @@
 
 // MARKER(update_precomp.py): autogen include statement, do not remove
 #include "precompiled_sw.hxx"
-#include <tools/debug.hxx>
 #include <vcl/window.hxx>
 #include <swtypes.hxx>
 
diff --git a/sw/source/core/access/accmap.cxx b/sw/source/core/access/accmap.cxx
index c552e67..2a6c725 100644
--- a/sw/source/core/access/accmap.cxx
+++ b/sw/source/core/access/accmap.cxx
@@ -35,8 +35,6 @@
 #include <vcl/window.hxx>
 #include <svx/svdmodel.hxx>
 #include <svx/unomod.hxx>
-#include <tools/debug.hxx>
-
 #include <map>
 #include <list>
 #include <accmap.hxx>
diff --git a/sw/source/core/access/accportions.cxx b/sw/source/core/access/accportions.cxx
index efd6c67..4bc211f 100644
--- a/sw/source/core/access/accportions.cxx
+++ b/sw/source/core/access/accportions.cxx
@@ -29,7 +29,6 @@
 // MARKER(update_precomp.py): autogen include statement, do not remove
 #include "precompiled_sw.hxx"
 #include "accportions.hxx"
-#include <tools/debug.hxx>
 #include <rtl/ustring.hxx>
 #include <com/sun/star/i18n/Boundary.hpp>
 #include <txttypes.hxx>
diff --git a/sw/source/core/access/accselectionhelper.cxx 
b/sw/source/core/access/accselectionhelper.cxx
index 85cfd2c..799560c 100644
--- a/sw/source/core/access/accselectionhelper.cxx
+++ b/sw/source/core/access/accselectionhelper.cxx
@@ -39,7 +39,6 @@
 #include <viewsh.hxx>
 #include <fesh.hxx>
 #include <vcl/svapp.hxx>        // for SolarMutex
-#include <tools/debug.hxx>
 #include <flyfrm.hxx>
 
 
diff --git a/sw/source/core/doc/SwStyleNameMapper.cxx b/sw/source/core/doc/SwStyleNameMapper.cxx
index e27a6ba..ac79022 100644
--- a/sw/source/core/doc/SwStyleNameMapper.cxx
+++ b/sw/source/core/doc/SwStyleNameMapper.cxx
@@ -36,7 +36,6 @@
 #include <tools/resmgr.hxx>
 #include <poolfmt.hxx>
 #include <rcid.hrc>
-#include <tools/debug.hxx>
 #ifdef _NEED_TO_DEBUG_MAPPING
 #include <stdlib.h>
 #endif
diff --git a/sw/source/core/text/wrong.cxx b/sw/source/core/text/wrong.cxx
index 9bc25b2..1599fec 100644
--- a/sw/source/core/text/wrong.cxx
+++ b/sw/source/core/text/wrong.cxx
@@ -31,7 +31,6 @@
 
 
 #include <tools/string.hxx>
-#include <tools/debug.hxx>
 #include "swtypes.hxx"
 #include "txttypes.hxx"
 
diff --git a/sw/source/core/tox/toxhlp.cxx b/sw/source/core/tox/toxhlp.cxx
index 0dd7661..6af7312 100644
--- a/sw/source/core/tox/toxhlp.cxx
+++ b/sw/source/core/tox/toxhlp.cxx
@@ -34,7 +34,6 @@
 #include <comphelper/processfactory.hxx>
 #include <com/sun/star/i18n/XExtendedIndexEntrySupplier.hpp>
 #include <tools/string.hxx>
-#include <tools/debug.hxx>
 #include <toxwrap.hxx>
 
 using namespace ::com::sun::star;
diff --git a/sw/source/core/unocore/swunohelper.cxx b/sw/source/core/unocore/swunohelper.cxx
index 162716d..498541f 100644
--- a/sw/source/core/unocore/swunohelper.cxx
+++ b/sw/source/core/unocore/swunohelper.cxx
@@ -44,7 +44,6 @@
 #include <comphelper/types.hxx>
 #include <tools/urlobj.hxx>
 #include <tools/datetime.hxx>
-#include <tools/debug.hxx>
 #include <ucbhelper/contentidentifier.hxx>
 #include <ucbhelper/contentbroker.hxx>
 #include <ucbhelper/content.hxx>
diff --git a/sw/source/core/unocore/unoidx.cxx b/sw/source/core/unocore/unoidx.cxx
index 25b84ca..dabc4ec 100644
--- a/sw/source/core/unocore/unoidx.cxx
+++ b/sw/source/core/unocore/unoidx.cxx
@@ -37,7 +37,6 @@
 #include <com/sun/star/text/BibliographyDataField.hpp>
 #include <com/sun/star/text/XTextDocument.hpp>
 
-#include <tools/debug.hxx>
 #include <osl/mutex.hxx>
 #include <vcl/svapp.hxx>
 #include <editeng/unolingu.hxx>
diff --git a/sw/source/core/unocore/unoprnms.cxx b/sw/source/core/unocore/unoprnms.cxx
index 493c2d0..8001606 100644
--- a/sw/source/core/unocore/unoprnms.cxx
+++ b/sw/source/core/unocore/unoprnms.cxx
@@ -28,7 +28,6 @@
 
 // MARKER(update_precomp.py): autogen include statement, do not remove
 #include "precompiled_sw.hxx"
-#include <tools/debug.hxx>
 #include <svl/itemprop.hxx>
 #include <unoprnms.hxx>
 
diff --git a/sw/source/core/unocore/unoredlines.cxx b/sw/source/core/unocore/unoredlines.cxx
index d977f2f..e2f4c75 100644
--- a/sw/source/core/unocore/unoredlines.cxx
+++ b/sw/source/core/unocore/unoredlines.cxx
@@ -31,7 +31,6 @@
 
 #include <com/sun/star/beans/XPropertySet.hpp>
 
-#include <tools/debug.hxx>
 #include <osl/mutex.hxx>
 #include <vcl/svapp.hxx>
 
diff --git a/sw/source/core/view/printdata.cxx b/sw/source/core/view/printdata.cxx
index b594109..35a979f 100644
--- a/sw/source/core/view/printdata.cxx
+++ b/sw/source/core/view/printdata.cxx
@@ -42,7 +42,6 @@
 #include <svl/languageoptions.hxx>
 #include <toolkit/awt/vclxdevice.hxx>
 #include <tools/string.hxx>
-#include <tools/debug.hxx>
 #include <tools/resary.hxx>
 #include <unotools/moduleoptions.hxx>
 #include <vcl/outdev.hxx>
diff --git a/sw/source/core/view/vprint.cxx b/sw/source/core/view/vprint.cxx
index f1a3794..ad9251a 100644
--- a/sw/source/core/view/vprint.cxx
+++ b/sw/source/core/view/vprint.cxx
@@ -44,7 +44,6 @@
 #include <editeng/pbinitem.hxx>
 #include <svx/svdview.hxx>
 #include <toolkit/awt/vclxdevice.hxx>
-#include <tools/debug.hxx>
 #include <unotools/localedatawrapper.hxx>
 #include <unotools/moduleoptions.hxx>
 #include <unotools/syslocale.hxx>
diff --git a/sw/source/filter/html/parcss1.cxx b/sw/source/filter/html/parcss1.cxx
index 2472562..6dc1138 100644
--- a/sw/source/filter/html/parcss1.cxx
+++ b/sw/source/filter/html/parcss1.cxx
@@ -34,7 +34,6 @@
 #include <stdio.h>
 #include <limits.h>
 #include <rtl/ustrbuf.hxx>
-#include <tools/debug.hxx>
 #include <vcl/svapp.hxx>
 #include <svtools/htmltokn.h>
 
diff --git a/sw/source/filter/writer/wrtswtbl.cxx b/sw/source/filter/writer/wrtswtbl.cxx
index 6cdc136..b1333fa 100644
--- a/sw/source/filter/writer/wrtswtbl.cxx
+++ b/sw/source/filter/writer/wrtswtbl.cxx
@@ -29,7 +29,6 @@
 // MARKER(update_precomp.py): autogen include statement, do not remove
 #include "precompiled_sw.hxx"
 #include <hintids.hxx>
-#include <tools/debug.hxx>
 #include <editeng/boxitem.hxx>
 #include <editeng/brshitem.hxx>
 #include <tools/fract.hxx>
diff --git a/sw/source/filter/ww1/w1class.hxx b/sw/source/filter/ww1/w1class.hxx
index 073ec06..87a057b 100644
--- a/sw/source/filter/ww1/w1class.hxx
+++ b/sw/source/filter/ww1/w1class.hxx
@@ -26,7 +26,6 @@
  *
  ************************************************************************/
 #include <tools/string.hxx>
-#include <tools/debug.hxx>
 
 // local
 #include <w1struct.hxx>
diff --git a/sw/source/filter/ww8/hash_wrap.hxx b/sw/source/filter/ww8/hash_wrap.hxx
index 348d2ef..52be41a 100644
--- a/sw/source/filter/ww8/hash_wrap.hxx
+++ b/sw/source/filter/ww8/hash_wrap.hxx
@@ -32,7 +32,6 @@
 #define WW_HASH_WRAP_HXX
 
 #include <boost/unordered_set.hpp>
-#include <tools/debug.hxx>
 
 //simple wrapper around boost::unordered_set to behave like sorted array
 namespace ww
diff --git a/sw/source/filter/ww8/needed_cast.hxx b/sw/source/filter/ww8/needed_cast.hxx
index 4a8c23c..462e6d0 100644
--- a/sw/source/filter/ww8/needed_cast.hxx
+++ b/sw/source/filter/ww8/needed_cast.hxx
@@ -29,7 +29,6 @@
 #ifndef WW_NEEDED_CAST_HXX
 #define WW_NEEDED_CAST_HXX
 
-#include <tools/debug.hxx>
 #include "staticassert.hxx"
 
 namespace ww
diff --git a/sw/source/filter/ww8/sortedarray.hxx b/sw/source/filter/ww8/sortedarray.hxx
index 6fccf66..f76646c 100644
--- a/sw/source/filter/ww8/sortedarray.hxx
+++ b/sw/source/filter/ww8/sortedarray.hxx
@@ -30,7 +30,6 @@
 #define WW_SORTEDARRAY_HXX
 
 #include <algorithm>
-#include <tools/debug.hxx>
 
 //simple template that manages a static [] array by sorting at construction
 
diff --git a/sw/source/filter/ww8/styles.cxx b/sw/source/filter/ww8/styles.cxx
index 1dde32e..ff11be6 100644
--- a/sw/source/filter/ww8/styles.cxx
+++ b/sw/source/filter/ww8/styles.cxx
@@ -35,7 +35,6 @@
 #include <algorithm>                //std::find_if
 #include <tools/string.hxx>         //do we have to...
 
-#include <tools/debug.hxx>
 #include "staticassert.hxx"      //StaticAssert
 
 namespace
diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index a99e489..baa2ee1 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -49,7 +49,6 @@
 #endif                      // dump
 #include <comphelper/processfactory.hxx>
 #include <unotools/localedatawrapper.hxx>
-#include <tools/debug.hxx>
 #include <i18npool/lang.h>
 #include <editeng/unolingu.hxx>
 #include <vcl/svapp.hxx>    // Application  #i90932#
diff --git a/sw/source/filter/xml/xmlbrsh.cxx b/sw/source/filter/xml/xmlbrsh.cxx
index cfe911e..fc9be6b 100644
--- a/sw/source/filter/xml/xmlbrsh.cxx
+++ b/sw/source/filter/xml/xmlbrsh.cxx
@@ -32,7 +32,6 @@
 
 
 #include "hintids.hxx"
-#include <tools/debug.hxx>
 #include <com/sun/star/io/XOutputStream.hpp>
 #include <editeng/memberids.hrc>
 
diff --git a/sw/source/filter/xml/xmlitem.cxx b/sw/source/filter/xml/xmlitem.cxx
index 6f5cf67..c94f27f 100644
--- a/sw/source/filter/xml/xmlitem.cxx
+++ b/sw/source/filter/xml/xmlitem.cxx
@@ -28,7 +28,6 @@
 
 // MARKER(update_precomp.py): autogen include statement, do not remove
 #include "precompiled_sw.hxx"
-#include <tools/debug.hxx>
 #include <xmloff/xmlimp.hxx>
 #include "xmlimpit.hxx"
 #include "xmlitem.hxx"
-- 
1.7.3.4