Hello all,
To my surprise, I found while checking documents with glow effects that
in f9fc420dceb1ece2c98767da16a21aaff771f140 three chunks of code were
deleted in sw/qa/extras/ooxmlexport/ooxmlexport7.cxx. See
https://cgit.freedesktop.org/libreoffice/core/diff/sw/qa/extras/ooxmlexport/ooxmlexport7.cxx?id=f9fc420dceb1ece2c98767da16a21aaff771f140
After some investigation I found:
- First block: asserts checking the glow effect were removed <- just
needed to be adapted.
- Second block: even non glow effect asserts were removed <- This
worries me more
- Third block: glow effect is no longer exported, causing a regression
<- also worries me
I fixed first and second points in
https://gerrit.libreoffice.org/c/core/+/92461 but I think unittests and
asserts are there for a reason and shouldn't be removed unless there is
a major reason to do. In this particular case, I can't find any
explanation why they were removed
Please, be consequent with your patches, I don't think removing old
unittest/asserts to make jenkins happy is the way to go.
Regards
--
Xisco FaulĂ
LibreOffice QA Team
IRC: x1sc0
Context
- asserts removed · Xisco Fauli
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.