On 03/04/2020 18:00, Miklos Vajna wrote:
My understanding is that in when svp is active and
comphelper::LibreOfficeKit::isActive() returns true, then the
expectation is that each view has its own clipboard. A "view" is the
Window -> New Window menu item. The LOK case wants this, as such a view
actually ends up in the web browser of different users. This is the same
as the "tiled rendering" case, these tests always set the LOK mode to
true.
When comphelper::LibreOfficeKit::isActive() return false, then then
expectation is that this is a desktop session where both views belong to
the same user, so a shared clipboard makes sense. The UITests probably
want to mimic the desktop case, so they would be in this category.
(Actually, any kind of test which is not a tiled rendering test.)
Does that help?
Thanks, that helped indeed. I've created
<https://gerrit.libreoffice.org/c/core/+/91869> "Make
SalInstance::CreateClipboard return a single instance in the non-LOK
case" now.
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.