Re: sd: disable pdf import tests

Stephan Bergmann <sbergman -AT- redhat.com>
Tue, 17 Dec 2019 19:49:11 +0100

On 17/12/2019 16:20, Ashod Nakashian wrote:

Fair enough. I think we can still keep your patch, but restore thedefines (i.e. keep them disabled) and I'll a comment/fixme (after youmerge) that we should restore these tests to work with PDFium etc.

Fair enough. Pushed as<https://gerrit.libreoffice.org/plugins/gitiles/core/+/78761f9b0177b0ae8ccfc5323a530fe4404b9637%5E%21>"Make disabled PDF import tests compile again".

(By the way, I'm not interested in the tests themselves at all, justcame across them in the context of<https://gerrit.libreoffice.org/plugins/gitiles/core/+/ced9702c9fcba0c702f0b910c3f1f5dae69a4f5a%5E!>"SdImportTest::testPDFImportShared fails for --disable-pdfium".)

Context

sd: disable pdf import tests · Stephan Bergmann
- Re: sd: disable pdf import tests · Stephan Bergmann
- Re: sd: disable pdf import tests · Ashod Nakashian
  - Re: sd: disable pdf import tests · Stephan Bergmann
    - Re: sd: disable pdf import tests · Ashod Nakashian
      - Re: sd: disable pdf import tests · Stephan Bergmann
        
        Re: sd: disable pdf import tests · Ashod Nakashian
        
        Re: sd: disable pdf import tests · Stephan Bergmann

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.