Date: prev next · Thread: first prev next last
2019 Archives by date, by thread · List index



On 12/17/19 9:52 AM, Stephan Bergmann wrote:
On 17/12/2019 15:29, Ashod Nakashian wrote:
So these tests aren't really useful anymore. They should be modified to do import+break and then check the results. But that isn't straight-forward and I ran out of time to do it.

In which case it would be great if you could either remove the non-useful tests (and I will abandon my <https://gerrit.libreoffice.org/#/c/85238/> "Re-enable PDF import tests") or document in sd/qa/unit/import-tests.cxx why these tests are currently disabled and that the plan is to modify and re-enable them.


Fair enough. I think we can still keep your patch, but restore the defines (i.e. keep them disabled) and I'll a comment/fixme (after you merge) that we should restore these tests to work with PDFium etc.

Is that reasonable ?


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.