Re: sd: disable pdf import tests

Ashod Nakashian <ashod.nakashian -AT- collabora.co.uk>
Tue, 17 Dec 2019 10:20:43 -0500


On 12/17/19 9:52 AM, Stephan Bergmann wrote:

On 17/12/2019 15:29, Ashod Nakashian wrote:
So these tests aren't really useful anymore. They should be modifiedto do import+break and then check the results. But that isn'tstraight-forward and I ran out of time to do it.
In which case it would be great if you could either remove thenon-useful tests (and I will abandon my<https://gerrit.libreoffice.org/#/c/85238/> "Re-enable PDF importtests") or document in sd/qa/unit/import-tests.cxx why these tests arecurrently disabled and that the plan is to modify and re-enable them.

Fair enough. I think we can still keep your patch, but restore thedefines (i.e. keep them disabled) and I'll a comment/fixme (after youmerge) that we should restore these tests to work with PDFium etc.


Is that reasonable ?

Context

sd: disable pdf import tests · Stephan Bergmann
- Re: sd: disable pdf import tests · Stephan Bergmann
- Re: sd: disable pdf import tests · Ashod Nakashian
  - Re: sd: disable pdf import tests · Stephan Bergmann
    - Re: sd: disable pdf import tests · Ashod Nakashian
      - Re: sd: disable pdf import tests · Stephan Bergmann
        
        Re: sd: disable pdf import tests · Ashod Nakashian
        
        Re: sd: disable pdf import tests · Stephan Bergmann

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.