ESC meeting minutes: 2019-11-21

* Present:
    + Stephan, Michael W, Heiko, Caolan, Gabriel, Cloph, Kendy, Olivier, Miklos, Xisco, Eike, 
Thorsten, Sophie, Michael S


* Completed Action Items:
   + committer welcome email to Pedro (Kendy)
   + Gifts to developers outside the regular contributors: write some guidelines on nominating 
(Olivier)
     + sent to the dev list

* Pending Action Items:
   + Propose new certified developers (Kendy, Stephan, Thorsten)
     + still waiting
   + update the ReleaseBuilds wiki page after release baseline for macOS has changed to Cathalina + 
xcode11 (Cloph)

* Release Engineering update (Cloph)
   + 6.4: beta1 on the mirror network
     + hard UI / string freeze mid-December → first RC
     + Late features?
          + tdf#97926 Add UNO API for Infobar ( Samuel )
         + objections? => nobody
       + ODF tender, perhaps (Thorsten)
         + ODF 1.3 on the UI, dialog / string change might be needed
         + why not add it now + hide it? (Caolan)
           + could do (Thorsten)
   + 6.3: 6.3.4 rc1 is due this week (waiting for pending reviews)
     + xslt bump, etc.

     + api.libreoffice.org is still at 6.2; usually Timar updates this manually, regularly 
forgotten (Miklos)
       + perhaps updating this could be part of the normal release process by TDF?
       + AI: file a redmine ticket for this (Cloph)
   + Remotes
   + Android viewer
     + break iterators fixed (Cloph)
     + manual page breaks fixed
     + testing + uploading to the Play store
   + Online
     + libreoffice-6-4 branch is created
     + 6.4 beta1 tag is pushed

* Documentation (Olivier)
   + New Help
      + omega-xapian results page localized (ohallot)
      + bumped to 6.5
         + https://help.libreoffice.org/6.5/en-US/text/shared/05/new_help.html
   + Helpcontent2
     + Several help pages refactored, enhanced and updated,(ohallot)
       + re: PDF export with screenshots
     + Bug fixes and improvements (ohallot)
   + Google Season of Doc
     + Advancing, on schedule (Aaron Peters)
     + reviewing chapters (ohallot)
     + start assembling the book this week (Aaron)
     + see in Nextcloud, LibreOffice Documentation folder
     + expect to be finished by the end of Nov
   + Guides
     + stalled
   + Do you need review help? (Sophie)
     + yes (Olivier)


* UX Update (Heiko)
   + Bugzilla (topicUI) statistics
       231(231) (topicUI) bugs open, 247(247) (needsUXEval) needs to be evaluated by the UXteam
   + Updates:
       BZ changes   1 week    1 month    3 months   12 months
            added      8(-6)     20(-7)     39(-12)    104(-5)
        commented     90(-25)   296(-24)   801(-29)   2205(11)
          removed      1(1)       1(1)       1(1)       16(0)
         resolved     13(7)      25(8)      83(7)      206(10)
   + top 10 contributors:
         Heiko Tietze made 209 changes in 1 month, and 869 changes in 1 year
         dieterp made 59 changes in 1 month, and 300 changes in 1 year
         Kainz, Andreas made 54 changes in 1 month, and 270 changes in 1 year
         Xisco Faulí made 52 changes in 1 month, and 358 changes in 1 year
         Foote, V Stuart made 47 changes in 1 month, and 384 changes in 1 year
         Seth Chaiklin made 19 changes in 1 month, and 24 changes in 1 year
         Thomas Lendo made 19 changes in 1 month, and 265 changes in 1 year
         Cor Nouws made 14 changes in 1 month, and 164 changes in 1 year
         Timur made 13 changes in 1 month, and 71 changes in 1 year
         Mehrbrodt, Samuel made 11 changes in 1 month, and 96 changes in 1 year

    + New tickets with needsUXEval Nov/14-21

     * Contextual Single mode with bad spacing and ugly lines; should look the
       same as Single Toolbar mode
       + https://bugs.documentfoundation.org/show_bug.cgi?id=128933
     * Enter a half-width character at begining of line , The Language change
       from Japanese to English.
       + https://bugs.documentfoundation.org/show_bug.cgi?id=127491

 ->  * Options -> Load/Save -> VBA Properties Options for MSO 97/2000/XP
       + https://bugs.documentfoundation.org/show_bug.cgi?id=128924

       + could we go with “Microsoft Office” there? (Heiko)

         => no objections

     * EDITING: “Enter“ in first Cell of Table Creates a Paragraph above Table
       + https://bugs.documentfoundation.org/show_bug.cgi?id=71501
     * Navigator: right-clicking on any item should bring context menu as
       right-clicking the item in document, not custom navigator menu
       + https://bugs.documentfoundation.org/show_bug.cgi?id=128814
     => in discussion, unconfirmed

     * PARAGRAPH STYLE: Index headings should have outline-level 1 by default
       + https://bugs.documentfoundation.org/show_bug.cgi?id=128858
     => accepted

     * Duplicate choice right above Delete choice -- bad design
       + https://bugs.documentfoundation.org/show_bug.cgi?id=128757
     => easyhack

     * Is the explanation clear in tip nr. 14 about selection zooming?
       + https://bugs.documentfoundation.org/show_bug.cgi?id=128712
     => assigned

     * UI Pop-up menu for fast access
       + https://bugs.documentfoundation.org/show_bug.cgi?id=128834
     => dup

->  + Guideline on dialog layout ready for review
     + https://nextcloud.documentfoundation.org/s/piF7DnPAaY7yS4f
     + Caolan commented

* Crash Testing (Caolan)
   + 22(+1) import failure, 223(-31) export failures
     + most of it is a fallout from docx export work – duplicated attributes
     + plan to revert for now (Caolan)
     + also footnote-related problems, can be a fallout from work of Jan-Mark and/or Miklos
   + 10 coverity issues
   + 17 oss-fuzz issues, 11 are timeouts

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/6.2.7.1
        + (+134) 1607 1473 1256 1378 1607 1549 2481 1309 959 673 186 0
    + https://crashreport.libreoffice.org/stats/version/6.2.8.2
        + (+247) 815 568 375 320 198 0
    + https://crashreport.libreoffice.org/stats/version/6.3.1.2
        + (-59) 1238 1297 1162 1454 1783 2151 3406 2696 2886 2262 820 0
    + https://crashreport.libreoffice.org/stats/version/6.3.2.2
        + (-498) 3124 3622 3487 4392 3950 3273 4801 1698 0
    + https://crashreport.libreoffice.org/stats/version/6.3.3.2
        + (+809) 2629 1820 854 0

* Hackfests & Events (Thorsten)
  + hope to have one each quarter.
  + plans for next year:
    + FOSDEM 2020
      + devroom is approved, will be on Saturday
      + CfP deadline is end of November (Michael)
        + next week: need to submit your proposals!

* mentoring/easyhack update
         committer...   1 week      1 month     3 months     12 months
                 open       97(28)     161(30)      168(34)      181(34)
              reviews     1540(293)   4997(236)   13179(208)   55036(393)
               merged      417(14)    1652(65)     4690(28)    17076(-20)
            abandoned       14(-4)      80(-9)      210(-8)      832(-8)
          own commits      314(-42)   1480(-26)    3935(-14)   14677(-109)
       review commits       66(-20)    346(-13)     915(-32)    4269(-22)
       contributor...   1 week     1 month    3 months    12 months
                 open      10(0)      29(3)       30(3)       32(3)
              reviews     174(-22)   673(28)    2041(4)     3910(126)
               merged      22(12)     48(14)     152(5)      884(172)
            abandoned     148(146)   155(148)    173(142)    468(154)
          own commits      27(9)      86(16)     194(10)     954(13)
       review commits       0(0)       0(0)        0(0)        0(0)
   + easyHack statistics:
      needsDevEval 6(6)   needsUXEval 1(1)   cleanup_comments 198(198)
      total 245(245)   assigned 3(3)   open 226(226)
   + top 10 contributors:
         LibreOfficiant made 16 patches in 1 month, and 72 patches in 1 year
         Balazs Varga made 10 patches in 1 month, and 59 patches in 1 year
         Pranam Lashkari made 5 patches in 1 month, and 5 patches in 1 year
         Mattia Rizzolo made 4 patches in 1 month, and 4 patches in 1 year
         Tünde Tóth made 4 patches in 1 month, and 34 patches in 1 year
         Seth Chaiklin made 4 patches in 1 month, and 4 patches in 1 year
         himajin100000 made 2 patches in 1 month, and 26 patches in 1 year
         Attila Bakos made 2 patches in 1 month, and 2 patches in 1 year
         Ricardo Palomares made 2 patches in 1 month, and 4 patches in 1 year
         Marco A.G.Pinto made 2 patches in 1 month, and 9 patches in 1 year
   + top 10 reviewers:
         Vajna, Miklos made 147 review comments in 1 month, and 1546 in 1 year
         Behrens, Thorsten made 121 review comments in 1 month, and 1644 in 1 year
         Michael Stahl made 108 review comments in 1 month, and 1462 in 1 year
         Bergmann, Stephan made 103 review comments in 1 month, and 1055 in 1 year
         Holešovský, Jan made 102 review comments in 1 month, and 888 in 1 year
         Xisco Faulí made 90 review comments in 1 month, and 970 in 1 year
         Adolfo Jayme Barrientos made 89 review comments in 1 month, and 903 in 1 year
         Timar, Andras made 88 review comments in 1 month, and 1268 in 1 year
         Meeks, Michael made 87 review comments in 1 month, and 596 in 1 year
         Grandin, Noel made 82 review comments in 1 month, and 1131 in 1 year
   + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
         Seth Chaiklin

* Commit Access
   + None

* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
   + sleep -2 weeks

* Jenkins / CI update (Christian)
   from:Thu Nov 14 14:39:31 2019
   master linux rel  jobs:  77 ok:  77 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master linux dbg  jobs:  66 ok:  62 ko:   4 fail ratio:  6.06 % break:   4 broken duration: 5.38%
   master mac rel    jobs:  27 ok:  27 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master mac dbg    jobs:  27 ok:  25 ko:   2 fail ratio:  7.41 % break:   2 broken duration: 3.44%
   master win rel    jobs:  81 ok:  71 ko:  10 fail ratio: 12.35 % break:   9 broken duration:15.71%
   master win dbg    jobs:  96 ok:  85 ko:  11 fail ratio: 11.46 % break:  11 broken duration:14.05%
   master win64 dbg  jobs:  89 ok:  77 ko:  12 fail ratio: 13.48 % break:  12 broken duration:10.50%
   master gerrit lin jobs: 752 ok: 590 ko:  81 fail ratio: 10.77% time for ok: mean:  20 median:  19
   master gerrit plg jobs: 777 ok: 547 ko: 125 fail ratio: 16.09% time for ok: mean:  27 median:  26
   master gerrit win jobs: 775 ok: 543 ko: 144 fail ratio: 18.58% time for ok: mean:  55 median:  55
   master gerrit mac jobs: 768 ok: 575 ko:  81 fail ratio: 10.55% time for ok: mean:  39 median:  25
   master gerrit all jobs: 602 ok: 327 ko: 159 fail ratio: 26.41% time for ok: mean: 120 median: 110
  + https://dev-www.libreoffice.org/tmp/gerrit_191121.html
  + tests that failed more than twice in last seven days:
     3 CppunitTest_sc_addin_functions_test
     3 CppunitTest_sw_ooxmlimport
     3 CppunitTest_sw_unowriter
     3 CppunitTest_writerperfect_writer
     5 CppunitTest_sw_layoutwriter
     5 UITest_textCase
     5 UITest_writer_tests5
     7 CppunitTest_sw_uwriter
    13 CppunitTest_sw_uiwriter
  + more builds this week (compared to usual)

* l10n (Sophie)
  + weblate instance status: migrating to a newer version
  + also to final hardware

* Graphics architecture (Thorsten)
 * https://pad.documentfoundation.org/p/ESC_graphics_architecture
 * skia status: see the updated feature/skia branch in core.git (Miklos)
   * hope to merge this branch to master after the libreoffice-6-4 branch-off
   * current defaults: enabled build-time, disabled runtime
     (later: replace the OpenGL default with skia+vulkan on Windows)
     * plan to merge it early next week
     * proposing it as Windows default only later (perhaps late in the 6.5 cycle) (Miklos)
     * OpenGL was a bad choice for users, happy to see it going away (Thorsten)
 * watch the dev list for detailed questions (Thorsten)

* docx/xlsx-aggressive-competitors (Miklos)
 + docx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128194 7 open bugs
 + xlsx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128382 4 open bugs
  + unchanged from last week

* require make 4.0? (Michael S)
 + confused developers run configure with make 4.0 then run make 3.81 from
   Xcode and it breaks mysteriously
 + even if configure sees a newer make, the actual build may see the older one
 + though, RHEL7 doesn’t have make 4.0 yet (have it in devtools)
   + should be fine from the Red Hat side (Caolan)
 + proposal: just require newer make and fail hard on older versions
 + AI: make it a requirement on master (Michael S)

* QA update (Xisco)

   + https://bugs.documentfoundation.org/show_bug.cgi?id=128882
        + LibreOffice 6.4 beta1 for mac → newer build is meant to fix this
     + was built on the wrong baseline

   + Please help flesh out the monthly reports:
         https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

   + UNCONFIRMED: 575 (+16)
       + enhancements: 67  (-9)
       + needsUXEval: 2 (-5)
       + haveBackTrace: 0 (+0)
       + needsDevAdvice: 13 (+0)
       + documentation:  9 (-1)
       + android:  6 (+0)
       + iOS:  2 (+1)
       + Online:  15 (+1)



   + Most pressing bugs:
    New:
    Old:
        + Save-As behavior on MacOS Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=126638
           + not happening for everyone

        + After Update to 6.1.4 on macOS fonts are blurred on retina
display (xcode 10)
           + https://bugs.documentfoundation.org/show_bug.cgi?id=122218
             + probably depends on xcode version (Xisco)
             + but newer xcode is required by notorization (Cloph)
               + ideal would be to build with xcode 10 entirely
               + HiDPI screen for Cloph would be great (Michael)
               + found out: not a regression, but it is from a user’s PoV
    Fixed:


   + New high severity bugs of the week:
       + Libreoffice Notebookbar is not exposing accessible events needed for screen reader users.
           + https://bugs.documentfoundation.org/show_bug.cgi?id=109425
           + implementation error, not a regression (Miklos)

       + EDITING: cannot modify a bibliography entry after creating it
           + https://bugs.documentfoundation.org/show_bug.cgi?id=128845
           + regression, Noel ?

       + Unable to open tables in HSQLDB odb-files with apostrophe " ' " character in table name
           + https://bugs.documentfoundation.org/show_bug.cgi?id=128862
           + regression, Noel ?

       + Cannot add AutoCorrect entries once the user/autocorr/acor_xx-XX.dat file is created
           + https://bugs.documentfoundation.org/show_bug.cgi?id=128659
           + regression, Noel ?

       + When execute undo, Text box moves.
           + https://bugs.documentfoundation.org/show_bug.cgi?id=128782                         + 
regression, Vasily ?

* QA stats
   + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
     +157  -30 (-143) overall)
     many thanks to the top bug squashers:
      QA Administrators       15
      Xisco Faulí             14
      Caolán McNamara         12
      Heiko Tietze            10
      Timur                   8
      V Stuart Foote          7
      Balázs Varga            5
      andreas_k               5
      Oliver Brinzing         5
      Buovjaga                4

   + top 10 bugs reporters:
      NISZ LibreOffice Team   13
      Xisco Faulí             6
      ken graebe              4
      Gerhard Weydt           4
      thekswenson             2
      Roman Kuznetsov         2
      sdc.blanco              2
      Mike Kaganski           2
      csongor                 2
      Luke                    2

   + top 10 bugs fixers:
      McNamara, Caolán        11
      Balazs Varga            5
      Kainz, Andreas          5
      Németh, László          3
      Glogowski, Jan-Marek    3
      Vajna, Miklos           3
      Tünde Tóth              3
      Justin L                2
      Michael Stahl           2
      Nabet, Julien           2

   + top 10 bugs confirmers:
      Xisco Faulí             31
      dieterp                 12
      Heiko Tietze            11
      Nabet, Julien           8
      *UNKNOWN*               8
      Timur                   7
      Alex Thurgood           5
      Brinzing, Oliver        5
      Foote, V Stuart         3
      Henschel, Regina        3


* Highest-Priority bugs (aka "MABs"):
  + http://bit.ly/2lJAAJI
    6.0 : 1/52 -     1 %  (+0)
    5.4 : 1/40 -     2 %  (+0)
    5.3 : 0/53 -     0 %  (+0)
    5.2 : 0/43 -     0 %  (+0)
    5.1 : 0/35 -     0 %  (+0)
    5.0 : 0/64 -     0 %  (+0)
    4.4 : 0/75 -     0 %  (+0)
    4.3 : 2/73 -     2 %  (+0)
    4.2 : 2/133 -    1 %  (+0)
    4.1 : 1/83 -     1 %  (+0)
    4.0 : 3/82 -     3 %  (+0)
    old : 4/242 -    1 %  (+0)


* Bisected bugs open: keyword 'bisected'
  + more accurate - down to a single commit.
  + http://bit.ly/2dyIfDy
  + 691/3723 693/3698 693/3670 696/3652 692/3633 694/3622 695/3606

    done by:
       Xisco Faulí            15
       Budea, Áron             3
       NISZ LibreOffice Team   3
       Raal                    1
       writepaperforme2        1


* Bibisected bugs open: keyword 'bibisected'
  + http://bit.ly/2cSCXlS
  + 864/4549 866/4524 866/4496 870/4478 865/4457 867/4444 868/4427

    done by:
       Xisco Faulí            16
       Budea, Áron             3
       NISZ LibreOffice Team   3
       Raal                    1


* all bugs tagged with 'regression'
  + 1149(-4) bugs open of 9057(+28) total 2(+0) high prio.

    done by:
       Xisco Faulí             9
       NISZ LibreOffice Team   5
       Alex Thurgood           3
       Benes, Luke             2
       Timur                   2
       Telesto                 1
       Raal                    1
       Nabet, Julien           1
       Brinzing, Oliver        1
       Robert Großkopf         1


* ~Component   count net * high severity regressions
  + http://bit.ly/1HWHb3E
    UI            - 1(+0)
    Calc          - 1(+0)

  by OS:
    Linux         - 0(+0)
    All           - 1(+0)
    Windows       - 0(+0)
    Mac OS X      - 1(+0)


* ~Component   count net * all regressions
  + http://bit.ly/1BUdI8i
    Writer: other            - 314(+1)
    Calc                     - 223(-2)
    Impress                  - 129(-1)
    Writer: docx filter      - 77(+0)
    LibreOffice              - 68(-3)
    Draw                     - 45(+0)
    Borders                  - 40(+1)
    UI                       - 39(+0)
    Base                     - 37(+2)
    Writer: perf             - 35(+0)
    Writer: doc filter       - 32(+0)
    Crashes                  - 30(+0)
    graphics stack           - 29(+0)
    Writer: other filter     - 29(+0)
    RTL                      - 22(+0)
    filters and storage      - 22(+0)
    Printing and PDF export  - 20(+0)
    Chart                    - 18(-3)
    BASIC                    - 18(+0)
    framework                - 3(+0)
    sdk                      - 1(+0)