ESC meeting minutes: 2019-11-07

* Present:
    + Heiko, Michael W, Caolan, Cloph, Stephan, Ilmari, Oliver, Kendy, Miklos, Xisco, Sophie, 
Michael M, Eike, Gabriel


* Completed Action Items:

* Pending Action Items:
   + Propose new certified developers (Kendy, Stephan, Thorsten)

* Release Engineering update (Cloph)
   + 6.4 alpha: went as planned
     + branch-off is planned next week + feature-freeze + beta1
     + Late features?
       + Nothing at the moment
   + 6.3 status: 6.3.4 rc1 in 2 weeks
   + Remotes
      + Android remote: fresh release pending, incl. Building on newer SDK
      + tdf#118485 is fixed in git, when to expect it in Play store? (Miklos)
        + expect update later this week (Cloph)
   + Android viewer
      + tinderbox / arm builds are still broken when it comes to doc loading
         + Intel build not affected
      + even there after a ‘make clean’
        + fixed now (Cloph)
   + Online

* Documentation (Olivier)
   + New Help
      + Fixes in xapian search (ohallot, Guilhem)
   + Helpcontent2
      + updates and fixes in HC2 (libreofficiant, ohallot, fitoshido)
   + Google season of Doc
      + Work is on schedule.
   + Guides
      +stalled

* UX Update (Heiko)
   + Bugzilla (topicUI) statistics
       229(229) (topicUI) bugs open, 248(248) (needsUXEval) needs to be evaluated by the UXteam
   + Updates:
       BZ changes   1 week    1 month    3 months   12 months
            added      5(-4)     25(0)      51(-3)     108(1)
        commented     41(-21)   269(-31)   783(-69)   2120(16)
          removed      0(0)       0(0)       0(0)       17(0)
         resolved      2(-2)     18(-9)     75(-13)    192(-2)
   + top 10 contributors:
         Heiko Tietze made 164 changes in 1 month, and 764 changes in 1 year
         dieterp made 94 changes in 1 month, and 303 changes in 1 year
         Foote, V Stuart made 60 changes in 1 month, and 375 changes in 1 year
         Xisco Faulí made 35 changes in 1 month, and 336 changes in 1 year
         Kainz, Andreas made 33 changes in 1 month, and 242 changes in 1 year
         Thomas Lendo made 30 changes in 1 month, and 272 changes in 1 year
         *UNKNOWN* made 18 changes in 1 month, and 18 changes in 1 year
         John made 17 changes in 1 month, and 17 changes in 1 year
         Cor Nouws made 12 changes in 1 month, and 159 changes in 1 year
         zionoto made 11 changes in 1 month, and 11 changes in 1 year

  + New tickets with needsUXEval Nov/01-07

  -> * Numbering List Presets in Bulgarian (4x), Russian (4x), Serbian (4x)
       + https://bugs.documentfoundation.org/show_bug.cgi?id=128640
      * is it possible to hide localized numbering style when it’s not relevant? (Heiko)

     * UI: "Remove hyperlink" is missing in context menu for selected text
       + https://bugs.documentfoundation.org/show_bug.cgi?id=128555
  -> * Impress Page Setup dialog with a resolution of 1366 x 768 requires a lot
       of scrolling
       + https://bugs.documentfoundation.org/show_bug.cgi?id=126128
     => in discussion

     * STATUSBAR: Wrong page number after page break with renumbering
       + https://bugs.documentfoundation.org/show_bug.cgi?id=128626
     => dup

     * illegal char in a bookmark name
       + https://bugs.documentfoundation.org/show_bug.cgi?id=128521
     * Requesting a native 'Preview Handler' for Windows explorer shell
       + https://bugs.documentfoundation.org/show_bug.cgi?id=89964
     => new

 ->  * Add decorations to manual page break marker line showing the break's
       properties: "with page style" and "with page number"
       + https://bugs.documentfoundation.org/show_bug.cgi?id=128616
     => easyhack

  + Windows Seven EOL coming soon (Heiko)
    + propose: deprecate it in the next major release?
      + might be too early (Ilmari)
    + still 30% market share → need to wait more
    + let’s wait for a technical reason (Cloph)
    => just keep it in mind for now

* Crash Testing (Caolan)
   + 25(+7) import failure, 3(-23) export failures
     - docx footnotes, new asserts, etc
   + 29 coverity issues, build in queue 187 builds ahead of it
   + 17 oss-fuzz issues, 6 recent msword failures, recent field changes ?

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/6.2.7.1
        + (-122) 1256 1378 1607 1549 2481 1309 959 673 186 0
    + https://crashreport.libreoffice.org/stats/version/6.2.8.2
        + (+55) 375 320 198 0
    + https://crashreport.libreoffice.org/stats/version/6.3.1.2
        + (-292) 1162 1454 1783 2151 3406 2696 2886 2262 820 0
    + https://crashreport.libreoffice.org/stats/version/6.3.2.2
        + (-905) 3487 4392 3950 3273 4801 1698 0
    + https://crashreport.libreoffice.org/stats/version/6.3.3.2
        + (+854) 854 0
* Hackfests & Events (Thorsten)
  + hope to have one each quarter.
  + plans for next year:
    + FOSDEM 2020
      + devroom is approved, will be on Saturday
      + CfP deadline is end of November (Michael)

* mentoring/easyhack update
         committer...   1 week      1 month      3 months      12 months
                 open       76(14)     130(8)        131(-4)       144(-5)
              reviews     1223(51)    5135(-178)   13110(-366)   54772(-79)
               merged      344(6)     1563(-85)     4467(15)     16887(33)
            abandoned       27(9)       88(11)       209(10)       841(-30)
          own commits      290(-45)   1503(-157)    3712(-36)    14676(-37)
       review commits       76(-15)    370(-51)      981(-48)     4318(9)
       contributor...   1 week    1 month   3 months    12 months
                 open      14(2)     23(1)      24(0)       26(1)
              reviews     191(82)   678(-8)   1952(-76)   3652(54)
               merged      23(1)    137(-3)    264(7)      843(10)
            abandoned       3(0)     12(1)      39(-27)    337(2)
          own commits      31(-5)   166(1)     304(9)     1076(6)
       review commits       0(0)      0(0)       0(0)        0(0)
   + easyHack statistics:
      needsDevEval 6(6)   needsUXEval 1(1)   cleanup_comments 196(196)
      total 241(241)   assigned 3(3)   open 222(222)
   + top 10 contributors:
         Pedro Pinto da Silva made 100 patches in 1 month, and 115 patches in 1 year
         LibreOfficiant made 14 patches in 1 month, and 68 patches in 1 year
         Balazs Varga made 5 patches in 1 month, and 53 patches in 1 year
         Mattia Rizzolo made 4 patches in 1 month, and 4 patches in 1 year
         Szabolcs Tóth (NISZ) made 2 patches in 1 month, and 8 patches in 1 year
         Ricardo Palomares made 2 patches in 1 month, and 4 patches in 1 year
         himajin100000 made 2 patches in 1 month, and 26 patches in 1 year
         Tünde Tóth made 1 patches in 1 month, and 30 patches in 1 year
         JohannKokos made 1 patches in 1 month, and 1 patches in 1 year
         Rasmus Thomsen made 1 patches in 1 month, and 1 patches in 1 year
   + top 10 reviewers:
         Kłos, Szymon made 215 review comments in 1 month, and 479 in 1 year
         Timar, Andras made 158 review comments in 1 month, and 1276 in 1 year
         Vajna, Miklos made 158 review comments in 1 month, and 1540 in 1 year
         Holešovský, Jan made 138 review comments in 1 month, and 880 in 1 year
         Michael Stahl made 134 review comments in 1 month, and 1436 in 1 year
         Behrens, Thorsten made 125 review comments in 1 month, and 1637 in 1 year
         Grandin, Noel made 123 review comments in 1 month, and 1143 in 1 year
         Bergmann, Stephan made 121 review comments in 1 month, and 1049 in 1 year
         Adolfo Jayme Barrientos made 113 review comments in 1 month, and 948 in 1 year
         Kaganski, Mike made 79 review comments in 1 month, and 757 in 1 year
   + Patches automatically abandoned:
       tdf#100390 Export subpath endings to PPTX ( Bartosz Kosiorek )
           - https://gerrit.libreoffice.org/#/c/78247
       tdf#126127: Make nTmp smaller still, avoid -fsanitize=signed-integer-overflow ( Stephan 
Bergmann )
           - https://gerrit.libreoffice.org/#/c/74801
   + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
         Yunusemre Şentürk
         Attila Bakos

* Commit Access
   + Pedro Pinto Silva: 100+ commits to Online’s loleaflet side (Miklos)
     + AI: push the buttons (Kendy)

* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
   + sleep 0 weeks

* Gifts to developers outside the regular contributors (Olivier)

 * a bug, fixed in glade, helps us a lot
 * thinks this is more a marketing question (Kendy)
   * the ESC has no swag to send
 * please talk to marketing instead
 * AI: write some guidelines on how to submit names, ESC approves (Olivier)
  + be sure to also thank the person (Michael M)

* Jenkins / CI update (Christian)
   from:Thu Oct 31 15:08:13 2019
   master linux rel  jobs: 138 ok: 137 ko:   1 fail ratio:  0.72 % break:   1 broken duration: 0.20%
   master linux dbg  jobs:  92 ok:  83 ko:   6 fail ratio:  6.52 % break:   4 broken duration: 5.46%
   master mac rel    jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master mac dbg    jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master win rel    jobs: 112 ok:  96 ko:  16 fail ratio: 14.29 % break:  14 broken duration: 8.06%
   master win dbg    jobs: 114 ok: 106 ko:   8 fail ratio:  7.02 % break:   8 broken duration: 8.30%
   master win64 dbg  jobs: 113 ok:  98 ko:  15 fail ratio: 13.27 % break:  11 broken duration:10.31%
   lo-5.3 mac        jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   lo-5.4 mac        jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
   master gerrit lin jobs: 460 ok: 345 ko:  48 fail ratio: 10.43% time for ok: mean:  24 median:  21
   master gerrit plg jobs: 456 ok: 310 ko:  71 fail ratio: 15.57% time for ok: mean:  31 median:  28
   master gerrit win jobs: 454 ok: 294 ko:  71 fail ratio: 15.64% time for ok: mean:  49 median:  47
   master gerrit mac jobs: 449 ok: 326 ko:  48 fail ratio: 10.69% time for ok: mean:  41 median:  30
   master gerrit all jobs: 424 ok: 236 ko: 149 fail ratio: 35.14% time for ok: mean:  73 median:  58
  + https://dev-www.libreoffice.org/tmp/gerrit_191107.html
  + tests that failed more than twice in last seven days
     3 CppunitTest_desktop_lib
     3 CppunitTest_sw_mailmerge
     3 CppunitTest_sw_ooxmlexport2
     3 UITest_writer_tests
     4 CppunitTest_sw_uwriter
  + linux gcc builds now assisted by amazon EC2 instances if queue grows
    + watching how it works, what cost it causes (Cloph)
    + no clang, the idea is to bring down the load
  + updated git on linux buildslaves for (much) faster fetching of changeset
    git 1.8 can take more than 10min, git 2.12 finishes in less than a minute
  + changed the multi-job config to not kill already in progress builds


* l10n (Sophie)
  + weblate instance status: still discovering, feedback collection
  + already migrated from pootle for master, 6.3 may or may not be migrated
  + pondering also importing the old history, not sure if it will be worth it
  + new language: Malay
  + is Online migrated to weblate as well? (Miklos)
    + plan: do the same, at some state (Cloph)
    + perhaps better git integration
    + updated templates on both pootle/weblate and core/online
      + no project is on both (avoids confusion)

* Reduce the Poco dependency in Online (Kendy)
 * already removed some code that is non-controversial
 * some code: would be easy to implement using c++17
   * std::filesystem code
     * currently have to add an additional library
     * older compilers have it as std::experimental only
   * currently doing it via ifdef

* Graphics architecture (Thorsten)
 * https://pad.documentfoundation.org/p/ESC_graphics_architecture
 * skia status: see the updated feature/skia branch in core.git (Miklos)
   * hope to merge this branch to master after the libreoffice-6-4 branch-off
   * currently proposed defaults: enabled build-time, disabled runtime
     (later: replace the OpenGL default with skia+vulkan on Windows)


* docx/xlsx-aggressive-competitors (Miklos)
 + docx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128194 7 open bugs
 + xlsx metabug status: https://bugs.documentfoundation.org/show_bug.cgi?id=128382 4 open bugs
  + unchanged from last week


* minutes from last week missing (Xisco)

 * perhaps it was killed in the mod queue (Stephan)
 * Should I send the same email again ? ( Xisco )
   + help for the last week is great (Miklos)

* QA update (Xisco)
   + Please help flesh out the monthly reports:
         https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

   + UNCONFIRMED: 602 (+11)
       + enhancements: 91  (+12)
       + needsUXEval: 5 (+0)
       + haveBackTrace: 0 (+0)
       + needsDevAdvice: 13 (+0)
       + documentation:  11 (+2)
       + android:  11 (+0)
       + iOS:  11 (-2)
       + Online:  14 (+1)



   + Most pressing bugs:
    New:
    Old:
       + Save-As behavior on MacOS Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=126638
           + not happening for everyone

       + After Update to 6.1.4 on macOS fonts are blurred on retina
display (xcode 10)
           + https://bugs.documentfoundation.org/show_bug.cgi?id=122218
             + probably depends on xcode version (Xisco)
             + but newer xcode is required by notorization (Cloph)
               + ideal would be to build with xcode 10 entirely
               + HiDPI screen for Cloph would be great (Michael)
               + found out: not a regression, but it is from a user’s PoV
    Fixed:
       + button flashing - mouse wheel zooming breaks
           + https://bugs.documentfoundation.org/show_bug.cgi?id=121963
           + Thanks to Armin


   + New high severity bugs of the week:
       + Crash when Export as png
           + https://bugs.documentfoundation.org/show_bug.cgi?id=128549
           + bisection pending

       + Function call to any Finder dialog fails on macOS 10.15 Catalina with parallel LO 
installations
           + https://bugs.documentfoundation.org/show_bug.cgi?id=128233
           + Notarization problem. Yet another Catalina problem


* QA stats
   + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
     +142  -3 (-133) overall)
     many thanks to the top bug squashers:
      Xisco Faulí             25
      QA Administrators       22
      eisa01                  6
      Muhammet Kara           5
      Julien Nabet            4
      Buovjaga                4
      Timur                   3
      m.a.riosv               3
      Balázs Varga            3
      Bakos Attila            3

   + top 10 bugs reporters:
      Nicolas Christener      10
      Xisco Faulí             7
      Pablo                   6
      Nukool Chompuparn       4
      sdc.blanco              4
      Roman Kuznetsov         4
      ricky.tigg              3
      Olivier Hallot          3
      Aron Budea              2
      Alex                    2

   + top 10 bugs fixers:
      Xisco Faulí             6
      Muhammet Kara           5
      Balazs Varga            3
      McNamara, Caolán        3
                              2
      Olivier Hallot          2
      Budea, Áron             2
      Lillqvist, Tor          2
      Vajna, Miklos           2
      Andras Timar            2

   + top 10 bugs confirmers:
      Xisco Faulí             42
      Brinzing, Oliver        12
      dieterp                 10
      *UNKNOWN*               8
      Heiko Tietze            7
      Roman Kuznetsov         7
      Timur                   6
      eisa01                  4
      Buovjaga                3
      Foote, V Stuart         3


* Highest-Priority bugs (aka "MABs"):
  + http://bit.ly/2lJAAJI
    6.0 : 1/52 -     1 %  (+0)
    5.4 : 1/40 -     2 %  (+0)
    5.3 : 0/53 -     0 %  (+0)
    5.2 : 1/44 -     2 %  (+0)
    5.1 : 0/35 -     0 %  (+0)
    5.0 : 0/64 -     0 %  (+0)
    4.4 : 0/75 -     0 %  (-1)
    4.3 : 2/73 -     2 %  (+0)
    4.2 : 2/133 -    1 %  (+0)
    4.1 : 1/83 -     1 %  (+0)
    4.0 : 3/82 -     3 %  (+0)
    old : 3/241 -    1 %  (-1)


* Bisected bugs open: keyword 'bisected'
  + more accurate - down to a single commit.
  + http://bit.ly/2dyIfDy
  + 695/3676 697/3658 689/3633 692/3624 695/3606 693/3586 688/3567

    done by:
       Xisco Faulí           13
       Raal                   2
       Terrence Enger         1
       Budea, Áron            1
       Buovjaga               1
       Brinzing, Oliver       1


* Bibisected bugs open: keyword 'bibisected'
  + http://bit.ly/2cSCXlS
  + 868/4502 870/4483 861/4457 865/4447 868/4427 867/4406 860/4384

    done by:
       Xisco Faulí           13
       Raal                   2
       Terrence Enger         1
       Budea, Áron            1
       Buovjaga               1
       Brinzing, Oliver       1


* all bugs tagged with 'regression'
  + 1149(-2) bugs open of 9000(+22) total 2(-1) high prio.

    done by:
       Xisco Faulí           10
       eisa01                 3
       Roman Kuznetsov        3
       dieterp                2
       Timur                  1
       Brinzing, Oliver       1


* ~Component   count net * high severity regressions
  + http://bit.ly/1HWHb3E
    UI            - 1(+0)
    Calc          - 1(-1)

  by OS:
    Mac OS X      - 1(+0)
    All           - 1(-1)
    Linux         - 0(+0)
    Windows       - 0(+0)


* ~Component   count net * all regressions
  + http://bit.ly/1BUdI8i
    Writer: other            - 315(+8)
    Calc                     - 223(-6)
    Impress                  - 130(+2)
    Writer: docx filter      - 79(-1)
    LibreOffice              - 69(-1)
    Draw                     - 44(+0)
    UI                       - 40(+0)
    Borders                  - 40(-1)
    Base                     - 36(+0)
    Writer: perf             - 35(+1)
    Writer: doc filter       - 32(-2)
    Crashes                  - 31(+0)
    Writer: other filter     - 30(+0)
    graphics stack           - 28(+1)
    RTL                      - 23(+0)
    filters and storage      - 22(-1)
    Printing and PDF export  - 19(+0)
    Chart                    - 18(+0)
    BASIC                    - 18(+0)
    framework                - 3(+0)
    sdk                      - 1(+0)
    Installation             - 0(-1)