ESC meeting minutes: 2019-10-31

* Present:
     + Olivier, Michael W, Ilmari, Caolan, Heiko, Kendy, Cloph, Xisco,
Gabriel, Michael M


* Completed Action Items:
    + Collect summary / pictures for each GSoC project (Heiko)
      [ No updates from mentors yet; probably drop if there’s no input from
        mentors! ]
      + draft: https://nextcloud.documentfoundation.org/s/XyMs94pqw5T44GW
      + still looking for input from everybody (except from Kendy and Heiko)
      =>
https://blog.documentfoundation.org/blog/2019/10/30/libreoffice-and-google-summer-of-code-2019-the-results/
(thanks to Mike S)

* Pending Action Items:
    + Propose new certified developers (Kendy, Stephan, Thorsten)

* Release Engineering update (Cloph)
    + 6.4 alpha: went as planned
      + branch-off is planned in 2 weeks + feature-freeze!
    + 6.3: 6.3.3 is announced
      + 6.3.4 rc1 in 3 weeks
    + Remotes
       + Android remote: fresh release pending, incl. Building on newer SDK
    + Android viewer
       + tinderbox / arm builds are still broken when it comes to doc
loading
          + Intel build not affected
       + even there after a ‘make clean’
    + Online

* Documentation (Olivier)
    + New Help
      + Update on icon replacement table (ohallot)
      + some time spent in XHP editor and gerrit (WIP) (ohallot)
    + Helpcontent2
      + Added screenshots in cui-related pages (WIP)
      + Housekeeping and bug squash (ohallot, libreofficiant, M kaganski)
    + Google seasons of doc
      + reviewing chapters
    + Guides
      + Team working on update the Calc guide
    + xapian: it’s already activated for 6.4
      + replaces the Google search
 
* UX Update (Heiko)


    + New tickets with needsUXEval Oct/25-31

      * Searchresult hard to find
        + https://bugs.documentfoundation.org/show_bug.cgi?id=128376
      * turn off autocapitalisation for date and whatever locale
        + https://bugs.documentfoundation.org/show_bug.cgi?id=128316
      => dup, wfm

      * Adding hyperlinks via the GUI to other sheets with only a number
        for the name in the same workbook take you to the ROW number
        in the current sheet, instead of to the target_sheet.a1
        + https://bugs.documentfoundation.org/show_bug.cgi?id=62289
      * Writer: Make multiple frame selectable
        + https://bugs.documentfoundation.org/show_bug.cgi?id=128394
      * MUFFIN mode for context menus only, similar to full-screen but
windowed
        + https://bugs.documentfoundation.org/show_bug.cgi?id=128349
      => new

      * restart manually numbering of numbered lists
        + https://bugs.documentfoundation.org/show_bug.cgi?id=128282
 ->   * TABLE-PROPERTIES: Add "Row" tab
        + https://bugs.documentfoundation.org/show_bug.cgi?id=128351
        + current usage is not too intuitive
 ->   * clone-brush needs more functions
        + https://bugs.documentfoundation.org/show_bug.cgi?id=128344
        + almost an Easter egg
      * PARAGRAPH STYLE DIALOG: "Reset" and "Standard" buttons:
confusing names
        + https://bugs.documentfoundation.org/show_bug.cgi?id=128469
      * Active Window drop-down in Navigation View Hogs Screen
        + https://bugs.documentfoundation.org/show_bug.cgi?id=128476
      => in dicussion

* Crash Testing (Caolan)
    + coverity: 24 (+2, -4)
    + crashtesting: 33 import failures, 27 export failures
        + calc dynamic row/cols. Fixes in gerrit
        + shape sorting out of bounds
        + “this is unused” assert in doc import
        + docx footnote import assert
    + oss-fuzz: 19 failures, 7 serious
        + all new writer failures

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/6.2.7.1
        + (-229) 1378 1607 1549 2481 1309 959 673 186 0
    + https://crashreport.libreoffice.org/stats/version/6.2.8.2
        + (+122) 320 198 0
    + https://crashreport.libreoffice.org/stats/version/6.3.0.4
        + (-1233) 3038 4271 4687 5401 5341 5370 5708 7000 6967 6267 4942
2052 0
    + https://crashreport.libreoffice.org/stats/version/6.3.1.2
        + (-329) 1454 1783 2151 3406 2696 2886 2262 820 0
    + https://crashreport.libreoffice.org/stats/version/6.3.2.2
        + (+442) 4392 3950 3273 4801 1698 0

* Hackfests & Events (Thorsten)
   + hope to have one each quarter.
   + plans for next year:
     + FOSDEM 2020
       + devroom is approved, will be on Saturday
       + CfP deadline is end of November (Michael)

* mentoring/easyhack update
          committer...   1 week       1 month      3 months      12
months   
                  open       57(-1)      120(7)        123(6)       
137(6)  
               reviews     1047(-501)   5318(-244)   13400(-599)  
54794(-314)
                merged      294(-174)   1652(-175)    4458(-105)  
16864(-59)
             abandoned       35(18)       93(15)       214(10)      
888(22) 
           own commits      308(-112)   1673(-40)     3744(-33)   
14691(-35)
        review commits       90(5)       419(36)      1024(0)      
4312(33) 
        contributor...   1 week     1 month     3 months     12 months 
                  open       9(-4)     20(-5)       23(-6)       24(-6)
               reviews     126(-95)   673(-129)   2003(-37)    3583(26)
                merged      23(1)     135(8)       257(8)       835(15)
             abandoned       4(1)      12(1)        41(-102)    336(-2)
           own commits      32(0)     161(18)      294(14)     1080(28)
        review commits       0(0)       0(0)         0(0)         0(0) 
    + easyHack statistics:
       needsDevEval 6(6)   needsUXEval 1(1)   cleanup_comments 197(197)  
       total 242(242)   assigned 3(3)   open 223(223)  
    + top 10 contributors:
          Pedro Pinto da Silva made 100 patches in 1 month, and 101
patches in 1 year
          LibreOfficiant made 8 patches in 1 month, and 62 patches in 1 year
          Balazs Varga made 6 patches in 1 month, and 53 patches in 1 year
          Mattia Rizzolo made 4 patches in 1 month, and 4 patches in 1 year
          Szabolcs Tóth (NISZ) made 4 patches in 1 month, and 8 patches
in 1 year
          Tünde Tóth made 2 patches in 1 month, and 30 patches in 1 year
          Ricardo Palomares made 2 patches in 1 month, and 4 patches in
1 year
          Dennis Schridde made 1 patches in 1 month, and 1 patches in 1 year
          Yunusemre Şentürk made 1 patches in 1 month, and 1 patches in
1 year
          Rasmus Thomsen made 1 patches in 1 month, and 1 patches in 1 year
    + top 10 reviewers:
          Kłos, Szymon made 229 review comments in 1 month, and 467 in 1
year
          Michael Stahl made 149 review comments in 1 month, and 1435 in
1 year
          Holešovský, Jan made 146 review comments in 1 month, and 876
in 1 year
          Timar, Andras made 144 review comments in 1 month, and 1259 in
1 year
          Vajna, Miklos made 144 review comments in 1 month, and 1534 in
1 year
          Grandin, Noel made 135 review comments in 1 month, and 1157 in
1 year
          Behrens, Thorsten made 129 review comments in 1 month, and
1636 in 1 year
          Bergmann, Stephan made 112 review comments in 1 month, and
1039 in 1 year
          Adolfo Jayme Barrientos made 105 review comments in 1 month,
and 944 in 1 year
          Kaganski, Mike made 91 review comments in 1 month, and 751 in
1 year
    + Patches automatically abandoned:
        tdf#100390 Export subpath endings to PPTX ( Bartosz Kosiorek )
            - https://gerrit.libreoffice.org/#/c/78247
        WIP: tdf#123263 assigning array with different element type
should fail ( himajin100000 )
            - https://gerrit.libreoffice.org/#/c/67585
    + big CONGRATULATIONS to contributors who have at least 1 merged
patch, since last report:
          Mayank Suman
          Yunusemre Şentürk
          Mattia Rizzolo
          Rasmus Thomsen
* Commit Access
    + None

* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
    + sleep 0 weeks

* Jenkins / CI update (Christian)
    from:Thu Oct 24 14:55:26 2019
    master linux rel  jobs: 169 ok: 164 ko:   5 fail ratio:  2.96 %
break:   1 broken duration: 1.21%
    master linux dbg  jobs:  74 ok:  69 ko:   3 fail ratio:  4.05 %
break:   2 broken duration: 3.35%
    master mac rel    jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 %
break:   0 broken duration: 0.00%
    master mac dbg    jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 %
break:   0 broken duration: 0.00%
    master win rel    jobs: 102 ok:  93 ko:   8 fail ratio:  7.84 %
break:   7 broken duration:11.54%
    master win dbg    jobs: 107 ok:  94 ko:  13 fail ratio: 12.15 %
break:  12 broken duration:10.21%
    master win64 dbg  jobs: 103 ok:  92 ko:  11 fail ratio: 10.68 %
break:   9 broken duration:10.73%
    lo-5.3 mac        jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 %
break:   0 broken duration: 0.00%
    lo-5.4 mac        jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 %
break:   0 broken duration: 0.00%
    master gerrit lin jobs: 401 ok: 291 ko:   9 fail ratio:  2.24% time
for ok: mean:  28 median:  26
    master gerrit plg jobs: 409 ok: 298 ko:  40 fail ratio:  9.78% time
for ok: mean:  36 median:  32
    master gerrit win jobs: 418 ok: 308 ko:  41 fail ratio:  9.81% time
for ok: mean:  54 median:  53
    master gerrit mac jobs: 408 ok: 298 ko:  61 fail ratio: 14.95% time
for ok: mean:  42 median:  27
    master gerrit all jobs: 374 ok: 227 ko: 118 fail ratio: 31.55% time
for ok: mean: 131 median:  88
   + https://dev-www.libreoffice.org/tmp/gerrit_191031.html
   + tests that failed more than twice in last seven days:
      3 CppunitTest_sw_uiwriter
     30 CppunitTest_sw_mailmerge → probably the changes were bad, not
the test
   + since there have been queue spikes again this week
     → setting up ec2 AMI to be used in peak-load times

* l10n (Sophie)
   + weblate instance status: still discovering, feedback collection
   + already migrated from pootle for master, 6.3 may or may not be migrated
   + pondering also importing the old history, not sure if it will be
worth it

* Graphics architecture (Thorsten)
  * https://pad.documentfoundation.org/p/ESC_graphics_architecture
  * skia status: see the updated feature/skia branch in core.git (Miklos)
    * hope to merge this branch to master after the libreoffice-6-4
branch-off
      * it would be built, but disabled run-time (by default)


* docx/xlsx-aggressive-competitors (Miklos)
  + docx metabug status:
https://bugs.documentfoundation.org/show_bug.cgi?id=128194 7 open bugs
  + xlsx metabug status:
https://bugs.documentfoundation.org/show_bug.cgi?id=128382 4 open bugs

* button flashing - mouse wheel zooming breaks (Xisco)
   + https://bugs.documentfoundation.org/show_bug.cgi?id=121963
   +
https://cgit.freedesktop.org/libreoffice/core/commit/?id=d464d505fbf6e53a38afdd3661d320fac8c760d6

   1. Complete revert
    - https://gerrit.libreoffice.org/#/c/81605/ - libreoffice-6-3
    - Pros: resolves all the regressions
    - Cons: not in master, conflicts might introduce other regressions,
6-4 branch off around the corner

   2. Partial revert
    - https://gerrit.libreoffice.org/#/c/81756/ - master, easy to backport
    - Cons: Might not fix all the regressions

   3. Wait for Armin’s fix
    - Pros: Best solution
    - Cons: No timeframe, late for 6.3


* QA update (Xisco)

   + Please help flesh out the monthly reports:
         https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

    + UNCONFIRMED: 570 (-10)
        + enhancements: 78  (-11)
        + needsUXEval: 6 (+1)
        + haveBackTrace: 0 (-2)
        + needsDevAdvice: 13 (-1)
        + documentation:  7 (+0)
        + android:  11 (+1)
        + iOS:  1 (-1)
        + Online:  13 (+0)
   + Most pressing bugs:
    New:
    [None]

    Old:
       + Save-As behavior on MacOS Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=126638
           + not happening for everyone

       + After Update to 6.1.4 on macOS fonts are blurred on retina
display (xcode 10)
           + https://bugs.documentfoundation.org/show_bug.cgi?id=122218
             + probably depends on xcode version (Xisco)
             + but newer xcode is required by notorization (Cloph)
               + ideal would be to build with xcode 10 entirely
               + HiDPI screen for Cloph would be great (Michael)
               + found out: not a regression, but it is from a user’s PoV

       + button flashing - mouse wheel zooming breaks
           + https://bugs.documentfoundation.org/show_bug.cgi?id=121963
               + Armin ?
              + 21 duplicates
              + even just identifying the problematic part of the commit
would be helpful (Xisco)

    + New high severity bugs of the week:
        + Always reproducible complete crash/lock of all LibreOffice
windows - data loss!
            + https://bugs.documentfoundation.org/show_bug.cgi?id=128077
            + Noel already submitted a fix, in progress

        + Presenter View of Impress 6.3.x doesn't remember slide after
Slides and Close, as it used to, but returns to 1 during presentation
            + https://bugs.documentfoundation.org/show_bug.cgi?id=127921
        + Patch in gerrit: https://gerrit.libreoffice.org/#/c/81833/

* QA stats

    + some stats are not complete (Xisco)
       + will take a look

    +
https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +124  +49 (-108) overall)
      many thanks to the top bug squashers:
       Xisco Faulí             20
       QA Administrators       8
       Eike Rathke             6
       Buovjaga                5
       V Stuart Foote          4
       Jim Raykowski           4
       Julien Nabet            4
       Caolán McNamara         4
       Adolfo Jayme            3
       Dieter Praas            3

    + top 10 bugs reporters:
       Nicolas Christener      10
       Xisco Faulí             9
       sdc.blanco              5
       John                    3
       Ming Hua                2
       Aron Budea              2
       Regina Henschel         2
       Roman Kuznetsov         2
       Telesto                 2
       erikmjacobs@gmail.com 1

    + top 10 bugs fixers:
       Xisco Faulí             6
       McNamara, Caolán        4
       Jim Raykowski           4
       Rathke, Eike            4
       Muhammet Kara           3
       Grandin, Noel           3
       Rizal Muttaqin          2
       Vajna, Miklos           2
       Glogowski, Jan-Marek    2
       Mehrbrodt, Samuel       2

    + top 10 bugs confirmers:
       Xisco Faulí             45
       Dieter Praas            17
       Nabet, Julien           13
       Alex Thurgood           6
       Brinzing, Oliver        6
       Heiko Tietze            6
       Raal                    4
       *UNKNOWN*               4
       Foote, V Stuart         4
       Timur                   4


* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     6.0 : 1/52 -     1 %  (+0)
     5.4 : 1/40 -     2 %  (+0)
     5.3 : 0/53 -     0 %  (+0)
     5.2 : 1/44 -     2 %  (+0)
     5.1 : 0/35 -     0 %  (+0)
     5.0 : 0/64 -     0 %  (+0)
     4.4 : 1/76 -     1 %  (+0)
     4.3 : 2/73 -     2 %  (+0)
     4.2 : 2/133 -    1 %  (+0)
     4.1 : 1/83 -     1 %  (+0)
     4.0 : 3/82 -     3 %  (+0)
     old : 5/243 -    2 %  (+0)


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        Xisco Faulí           10
        Brinzing, Oliver       3
        kompilainenn           1
        Terrence Enger         1
        Timur                  1
        Buovjaga               1
        Foote, V Stuart        1
 

* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        Xisco Faulí           10
        Brinzing, Oliver       4
        Timur                  2
        kompilainenn           1
        Kevin Suo              1
        Terrence Enger         1
        BogdanB                1


* all bugs tagged with 'regression'
   + 1147(-3) bugs open of 8979(+21) total 3(+0) high prio.

     done by:
        Xisco Faulí            8
        Brinzing, Oliver       2
        kompilainenn           1
        Alex Thurgood          1
        Kevin Suo              1
        Cor Nouws              1
        Dieter Praas           1
        Telesto                1
        Timur                  1
        Vajna, Miklos          1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Calc          - 2(+0)
     UI            - 1(+0)

   by OS:
     Linux         - 0(+0)
     All           - 2(+0)
     Mac OS X      - 1(+0)
     Windows       - 0(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 309(+2)
     Calc                     - 225(-5)
     Impress                  - 128(+1)
     Writer: docx filter      - 80(+1)
     LibreOffice              - 70(+0)
     Draw                     - 44(+0)
     Borders                  - 41(+1)
     UI                       - 40(-1)
     Base                     - 36(+0)
     Writer: perf             - 34(+0)
     Writer: doc filter       - 34(-1)
     Crashes                  - 31(+0)
     Writer: other filter     - 30(+1)
     graphics stack           - 27(+0)
     filters and storage      - 23(+0)
     RTL                      - 23(+1)
     Printing and PDF export  - 19(-1)
     BASIC                    - 18(+0)
     Chart                    - 17(+0)
     framework                - 3(+1)
     sdk                      - 1(+0)
     Installation             - 1(+1)





-- 
Xisco Faulí
Libreoffice QA Team
IRC: x1sc0