Re: About putting back Firebird experimental

 Hi Caolán,

Considering all the feedback, I submited https://bugs.documentfoundation.org/show_bug.cgi?id=127180 
about putting Migration + propose by default Firebird in experimental.
To fullfil this, reverting 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=8a1a9899e05b0ebbc3ff43f2db242724c8feb18f 
should respond to the second part.
For the first part, I'll take a look at the code pointer you proposed.

IMHO it should be in master branch + 6.3 branch.

Julien
     Le jeudi 22 août 2019 à 11:00:01 UTC+2, Caolán McNamara <caolanm@redhat.com> a écrit :  
 
 On Tue, 2019-08-20 at 14:51 +0200, Alexander Thurgood wrote:
> Le 20/08/2019 à 10:28, Julien a écrit :
>
> Hi Julien,
>
> +1 from me.
>
> As a QA triager, I can but agree with Julien given the current stage
> of development. The migration code still fails to handle multiple,
> basic elements of embedded hsqldb ODB files found in actual use.

The last time the firebird issue was brought to the ESC the outcome was
this commit[1] to keep the prompt to migrate, but set the default
button to "no" and add a link to 
https://wiki.documentfoundation.org/Documentation/HowTo/MigrateFromHSQLDB

The suggestion in the title of the email is about putting firebird as
experimental, but is the problem solely (or overwhelmingly) that of the
migration process ? Would changing the migration to be experimental,
while leaving the default for new databases as firebird, work ?

something like restoring a use of
SvtMiscOptions::IsExperimentalMode around
https://cgit.freedesktop.org/libreoffice/core/tree/dbaccess/source/core/dataaccess/datasource.cxx#n619


[1] 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=0b2eaf8c9595cc5f91b5d31b770e6f23e3b5b27c