Re: UI tests opening all possible dialogs

Hi,

I didn't had  contact with Raal yet. Added him and you to the reviewers
list.
It takes around 3min to run all tests of the commit on my laptop
(i5-4200U CPU @ 1.60GHz) and showing the UI. Using (LibreOffice Version:
6.3.0.0.beta1+
Build ID: 4904391e125eb66304a5c029def8d4c1a150952d)

Currently I'm compiling LO to see how long it takes with the make command.

Is there currently a way to run specific tests on nightly builds?

Am 22.06.19 um 14:55 schrieb Markus Mohrhard:
> Hello Artur,
>
> On Fri, Jun 21, 2019 at 12:06 PM Artur Neumann <artur@jankaritech.com
> <mailto:artur@jankaritech.com>> wrote:
>
>     Forgot the link to the changes, here it is:
>     https://gerrit.libreoffice.org/#/c/74333/
>
>     On 2019-06-20 5:01 p.m., Artur Neumann wrote:
> >     I've made some UI tests that open every dialog in calc, close it
> >     with the "close" or "cancel" button and if there is an "OK"
> >     button open it again and click the "OK" button
> >
> >     These tests should simply make sure there are no crashes by
> >     opening/closing the dialogues and protect against regressions like
> >     https://bugs.documentfoundation.org/show_bug.cgi?id=120227
> >     https://bugs.documentfoundation.org/show_bug.cgi?id=125982
> >     https://bugs.documentfoundation.org/show_bug.cgi?id=125985
> >
> >     I just wanted to have some feedback if picking those low-hanging
> >     fruits is a valid approach and worth the effort and CI time.
>
> I think that in general it is a good idea. Depending on how long it
> takes to execute the test we might need to think about whether we can
> actually include the tests in a normal make/make check or if they need
> to be treated differently. Did you already have a chat with Raal who
> has been writing tests for many bugs/dialogs already?
>
> >     If yes I could extend the tests by:
> >
> >      1. doing the same for writer, impress, etc.
> >      2. delete obsolete tests like uitest/calc_tests/about_test.py
> >      3. define preconditions for the "OK" click, e.g. input data into
> >         fields
> >      4. define assertion after the click on the "OK" button
>
> In general this sounds like a good idea. As mentioned it might be good
> to have a chat with Raal who might have an overview how far we are in
> opening all dialogs already.
>
> Regards,
> Markus
>
> >     Thoughts? Ideas?