Re: UI tests opening all possible dialogs

Hello Artur,

On Fri, Jun 21, 2019 at 12:06 PM Artur Neumann <artur@jankaritech.com>
wrote:

> Forgot the link to the changes, here it is:
> https://gerrit.libreoffice.org/#/c/74333/
> On 2019-06-20 5:01 p.m., Artur Neumann wrote:
>
> I've made some UI tests that open every dialog in calc, close it with the
> "close" or "cancel" button and if there is an "OK" button open it again and
> click the "OK" button
>
> These tests should simply make sure there are no crashes by
> opening/closing the dialogues and protect against regressions like
> https://bugs.documentfoundation.org/show_bug.cgi?id=120227
> https://bugs.documentfoundation.org/show_bug.cgi?id=125982
> https://bugs.documentfoundation.org/show_bug.cgi?id=125985
>
> I just wanted to have some feedback if picking those low-hanging fruits is
> a valid approach and worth the effort and CI time.
I think that in general it is a good idea. Depending on how long it takes
to execute the test we might need to think about whether we can actually
include the tests in a normal make/make check or if they need to be treated
differently. Did you already have a chat with Raal who has been writing
tests for many bugs/dialogs already?

If yes I could extend the tests by:
>    1. doing the same for writer, impress, etc.
>    2. delete obsolete tests like uitest/calc_tests/about_test.py
>    3. define preconditions for the "OK" click, e.g. input data into fields
>    4. define assertion after the click on the "OK" button
In general this sounds like a good idea. As mentioned it might be good to
have a chat with Raal who might have an overview how far we are in opening
all dialogs already.

Regards,
Markus

> Thoughts? Ideas?
>
> --
> Artur Neumann
> Director/CTO
> Jankari Tech Pvt Ltdwww.jankaritech.com
> Phone: +977 9806639223
> Skype: artur.n.
> GitHub: https://github.com/individual-it
>
>
> _______________________________________________
> LibreOffice mailing 
> listLibreOffice@lists.freedesktop.orghttps://lists.freedesktop.org/mailman/listinfo/libreoffice
>
> --
> Artur Neumann
> Director/CTO
> Jankari Tech Pvt Ltdwww.jankaritech.com
> Phone: +977 9806639223
> Skype: artur.n.
> GitHub: https://github.com/individual-it
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice