Date: prev next · Thread: first prev next last
2019 Archives by date, by thread · List index 

On 21/05/2019 12:06, julien2412 wrote:

sberg wrote

...
As I wrote, "though `javac --source 1.6 --target 1.6` apparently doesn't
check that".  So I guess to make such mistakes fail locally or for
Gerrit/Jenkins, you would need to actually use Java 6 to build there.


Taking a look to
https://opengrok.libreoffice.org/search?project=core&full=JAVA_TARGET_VER&defs=&refs=&path=&hist=&type=&si=full,
I don't see the use of "JAVA_SOURCE_VER" or "JAVA_TARGET_VER" var in
"scripting" part.
See gb_JavaClassSet_JAVACCOMMAND in solenv/gbuild/JavaClassSet.mk, which is what gets used by the scripting/Jar_*.mk. 


Reading
https://stackoverflow.com/questions/15492948/javac-source-and-target-options,
it seems even more complicated since we should use too "bootclasspath"
option too.
Ah, right, it was -bootclasspath that would allow javac to check that we don't use too new Java API features.

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.