Date: prev next · Thread: first prev next last
2019 Archives by date, by thread · List index 

Hi Noel,

Noel Grandin wrote:

Are we going to be doing this behind the
   VCL_FLOAT_DEVICE_PIXEL
define and using the DeviceCoordinate typedef ?


I'm assuming your referring to my recent patch:
https://gerrit.libreoffice.org/#/c/70329/ <https://gerrit.libreoffice.org/#/c/70329/>

That's a good point, do you mean doing something like:
#if VCL_FLOAT_DEVICE_PIXEL
    B2DPoint aCurrPos(0.0, 0.0);
#else
    B2IPoint aCurrPos(0, 0);
#endif



(as a side note I had no idea we had this enabled on mac and ios already)


That's interesting, I didn't know that. I've OpenGrok searched the code for
where we are doing this but I couldn't find it. I found line 10247 in
configure.ac, which looks related:
https://opengrok.libreoffice.org/xref/core/configure.ac?r=c51b68dd#10247 
<https://opengrok.libreoffice.org/xref/core/configure.ac?r=c51b68dd#10247>
But it's commented out (line starts with dnl).


With many thanks,
Alex

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.