Date: prev next · Thread: first prev next last
2019 Archives by date, by thread · List index


Hi Alex,

Alexander Farrow wrote:
basegfx::B2DPoint
<https://docs.libreoffice.org/basegfx/html/classbasegfx_1_1B2DPoint.html>
does not have such a method. So calls to AdjustX(nHorzMove) are
being replaced by something like setX(getX() + nHorzMove).

tools::Point is not exactly a role model for a nicely designed class,
so I'd hesitate to take any literal bits out of that. ;)

Many places using AdjustX() also call AdjustY() just the next line, so
for that you could use basegfx::B2DPoint::operator+=(const B2DTuple&)

If you believe you *must* use a single-component modifier, please come
up with something that blends well with the b2dtuple/point
concept. Also ideally, you will maintain some amount of internal
consistency (e.g. compare how operator*, *= etc. all got added in
farious flavours, such that math with b2dtuples works like the
'canonical' way when done with skalars or various forms of vectors).

Cheers,

-- Thorsten

Attachment: signature.asc
Description: PGP signature


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.