Date: prev next · Thread: first prev next last
2019 Archives by date, by thread · List index


On Thu, 2019-01-31 at 16:26 +0000, Crashtest VM wrote:
New crashtest update available at 
http://dev-builds.libreoffice.org/crashtest/3a2c2ad839860dcb36e30ae1a2867e4d5e1036fc/


Those export to .rtf asserts/crashes begun at...

commit 18bb85aa303c17b7705a9ccb0dd3d76673a1955e
Author: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
Date:   Sat Jan 12 12:04:04 2019 +0100

    make SwFormat a ::sw::BroadcastingModify
    
    - clean up SwSection..Hint: Lazily reusing the Dying HintId is evil
    - switch the SwChartDataSequence to SvtListener
    - add some description to RuntimeException

And if I revert just the SwChartDataSequence hunk it doesn't. 

Comparing what happens in the old ::Modify vs new ::Notify, in the new
case we get additional FindUnoInstanceHint hints which didn't seem to
arrive in the ::Modify case. The additional hints trigger modified in
SwChartDataSequence::Notify which didn't happen before which seems to
be the problem ?

This hackaround at https://gerrit.libreoffice.org/#/c/67394/ seems to
give the original behaviour, though I'm unsure if that's the right way
to go.


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.