Date: prev next · Thread: first prev next last
2018 Archives by date, by thread · List index


On 17.11.2017 10:03, Stephan Bergmann wrote:
* Don't reformat when moving an existing file

When moving an old file that is listed in solenv/clang-format/blacklist (so doesn't automatically get reformatted upon commit), adapt solenv/clang-format/blacklist to contain the new name, instead of provoking a reformat upon commit.  Otherwise, if the reformatted code looks sufficiently different from the original, it's hard to impossible to keep track in the git history of which file was moved where.

Please also follow this advice when moving part of an existing file out to a new file, as happened e.g. at <https://cgit.freedesktop.org/libreoffice/core/commit/?id=bdd62b4c327ab894dbba00fe2e07696c1b7d9de6> "vcl: split painting bitmap functions to bitmappaint.cxx".

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.