Date: prev next · Thread: first prev next last
2018 Archives by date, by thread · List index


On 16.02.2018 09:55, Samuel Thibault wrote:
Miklos Vajna, on ven. 16 févr. 2018 09:24:38 +0100, wrote:
On Thu, Feb 15, 2018 at 06:58:42PM +0100, Samuel Thibault <sthibault@hypra.fr> wrote:
For now I have patched the build system to call the tool as the attached
patch does, does it look OK? (basically it's called along building the
image list in the UIC rule, I need to doublecheck the clean rule, but
the build rule works fine)

Please submit patches to gerrit:
<https://wiki.documentfoundation.org/Development/gerrit>, it's much
easier to review anything there. :-)

For reviews, sure, I'm here just asking whether the general approach is
fine, not an actual review of the implementation.

...but even that can be easier to answer if people see a full, working patch, which they can actually try out. (It doesn't need to be feature-complete, of course, just working well enough to demonstrate what is going on.)

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.