minutes of ESC call ...

* Present:
    + Miklos, Xisco, Olivier, Heiko, Stephan, Eike, Sophie, Christian,
    + Samuel, Michael S, Caolan, Michael M, Thorsten, David, Kendy

* Completed Action Items:
    + review HTML patch and submit
         [ tested on Mac & Windows and will merge to master (Olivier) ]

* Pending Action Items:
    + come up with a list of retiring committers to mail (Norbert)

* Release Engineering update (Christian)
   + no release this week
   + 5.4.5 RC1 – last week of Jan – right before FOSDEM.
   + 6.0 RC3 – due next week
        + announce planned last week of Jan.
        + late features
            + gpg4libre branch (Thorsten)
               [ should all be in plus a bug-fix corner-case crash
                 when people don’t have gpg installed, looks good for 6.0 ]
        + please remember to cherry-pick to libreoffice-6-0-0 +2 reviews for
          the final release.
   + Android
        + patches getting committed now; some reviews from Thorsten.
        + poking the Android tinderbox before doing a test release.
        + builds with bundled cairo: some memory wins (Michael)
   + Online
        + pending rc3 next.

* Documentation (Olivier)
   + Patch for activating new local help (olivier)
      + next: test packaging.
   + Books:
      + Still working on GS 6.0 book w/ community.
      + Started Calc Guide Update

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        254(254) (topicUI) bugs open, 317(317) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week    1 month   3 months   12 months  
             added      1(-4)      9(-2)    32(-4)     109(-2) 
         commented     34(-11)   154(8)    514(-25)   2084(-39)
           removed      0(0)       0(0)      2(0)       18(-3) 
          resolved      5(3)      19(2)     54(1)      227(-7) 
    + top 10 contributors:
          Tietze, Heiko made 56 changes in 1 month, and 985 changes in 1 year
          Thomas Linard made 46 changes in 1 month, and 46 changes in 1 year
          Philips, Yousuf made 39 changes in 1 month, and 803 changes in 1 year
          Foote, V Stuart made 25 changes in 1 month, and 324 changes in 1 year
          Cor Nouws made 19 changes in 1 month, and 184 changes in 1 year
          Xisco Faulí made 18 changes in 1 month, and 399 changes in 1 year
          Buovjaga made 18 changes in 1 month, and 219 changes in 1 year
          Thomas Lendo made 12 changes in 1 month, and 414 changes in 1 year
          Henschel, Regina made 10 changes in 1 month, and 127 changes in 1 year
          Telesto made 9 changes in 1 month, and 81 changes in 1 year

  + Discussed how direct formatting and styles are applied and reverted
    + (tdf#112852) with the suggestion of a style inspector
        → good topic for newbies
    + another one might be to rework shortcut assignment
        + KEY_A = A != KEY_<some non-latin char> = some non-latin char

    + two new people are showing up looking for easyhacks
        + (Abhishek Shrivastava – quickstarter & another).

* Crash Hunting (Caolan)
    + 80(+2) import failure, 760 (+760) export failures
        + still some calc threading issues pending.
    + 12 coverity
    + 44 fuzzers * 3 sanitizers+engine combos (asan+libfuzzer,
            ubsan+libfuzzer, asan+afl), writer html last added
        + html an exciting set

* Crash Reporter (Xisco)
    + http://crashreport.libreoffice.org/stats/version/5.3.6.1
        + 1020 (last 7 days) (down)
    + http://crashreport.libreoffice.org/stats/version/5.3.7.2
        + 1347 (last 7 days) (-)
    + http://crashreport.libreoffice.org/stats/version/5.4.3.2
          + 2297 (last 7 days) (down)
    + http://crashreport.libreoffice.org/stats/version/5.4.4.2
          + 1353 (last 7 days) (up)


* GSOC Application (Thorsten)
    + Markus working on it; deadline Tues 23rd
    + ~90% done

* Hackfests & Events (Michael)
    + FOSDEM hack-fest / meetings
        + dates confirmed (Monday + Tuesday), book your travel!
        + Hotel: La Grande Cloche over the street.
          + https://wiki.documentfoundation.org/Hackfest/FOSDEM2018
    + Hamburg TNG – 1st new-style hackfest
        + outlined for April 7/8th.
            + https://wiki.documentfoundation.org/Hackfests/HackfestTNG
        + checkout the tender for mentoring:
            + 
https://blog.documentfoundation.org/blog/2018/01/16/tender-consultancy-libreoffice-feature-implementation-incl-site-development-training-201801-01/
            + layers issues – one a dup; a large problem domain here.
    + still looking for people who want help learning how to fix
      their problems interactively at a hackfest.

* mentoring/easyhack update
          committer...   1 week     1 month      3 months    12 months   
                  open      73(-3)     137(-13)     139(-15)     142(-15)
               reviews     604(-13)   1762(3)      5008(215)   18666(-9) 
                merged     262(-51)   1062(-124)   3686(143)   12013(49) 
             abandoned      21(8)       52(-1)      258(16)      750(4)  
           own commits     407(81)    1194(69)     4322(231)   14808(325)
        review commits      58(-68)    293(-1)      914(13)     3094(58) 
        contributor...   1 week     1 month      3 months    12 months  
                  open      24(4)       53(7)        55(6)        58(5) 
               reviews     772(-22)   2626(-127)   8132(187)   25079(84)
                merged      26(2)       95(3)       271(4)      1225(7) 
             abandoned       3(-5)      21(1)        60(-2)      328(-8)
           own commits      20(-13)     90(0)       255(-2)      946(19)
        review commits       0(0)        0(0)         0(0)         0(0) 
    + easyHack statistics:
       needsDevEval 38(38)   needsUXEval 1(1)   cleanup_comments 206(206)   
       total 251(251)   assigned 22(22)   open 187(187)   
    + top 5 contributors:
          Gelmini, Andrea made 46 patches in 1 month, and 255 patches in 1 year
          Jim Raykowski made 7 patches in 1 month, and 20 patches in 1 year
          Ilmari Lauhakangas made 6 patches in 1 month, and 20 patches in 1 year
          Goncharuk, Lera made 5 patches in 1 month, and 18 patches in 1 year
          Johnny_M made 4 patches in 1 month, and 58 patches in 1 year
    + top 5 reviewers:
          Pootle bot made 261 review comments in 1 month, and 896 in 1 year
          Behrens, Thorsten made 155 review comments in 1 month, and 1171 in 1 year
          Stahl, Michael made 145 review comments in 1 month, and 2044 in 1 year
          Holešovský, Jan made 144 review comments in 1 month, and 1223 in 1 year
          Nabet, Julien made 99 review comments in 1 month, and 796 in 1 year
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Mert merttumer7@gmail.com 
          Olivier Tilloy olivier.tilloy@canonical.com 

* Commit Access

* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
    + sleep for 13 weeks.

* Jenkins / CI update (Christian)
    from:Thu Jan 11 16:02:03 2018
    master linux rel  jobs: 177 ok: 176 ko:   1 fail ratio:  0.56 % break:   1 broken duration: 
0.42%
    master linux dbg  jobs: 139 ok: 136 ko:   3 fail ratio:  2.16 % break:   1 broken duration: 
0.35%
    master mac rel    jobs: 128 ok: 125 ko:   3 fail ratio:  2.34 % break:   3 broken duration: 
0.85%
    master mac dbg    jobs: 114 ok: 112 ko:   2 fail ratio:  1.75 % break:   2 broken duration: 
0.27%
    master win rel    jobs:  86 ok:  71 ko:  15 fail ratio: 17.44 % break:  12 broken 
duration:16.96%
    master win dbg    jobs: 103 ok:  83 ko:  20 fail ratio: 19.42 % break:  11 broken 
duration:17.75%
    master win64 dbg  jobs: 100 ok:  76 ko:  24 fail ratio: 24.00 % break:  19 broken 
duration:18.98%
    lo-5.3 mac        jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    lo-5.4 mac        jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    branch gerrit all jobs:   0 ok:   0 ko:   0 fail ratio: 0.00%
    master gerrit lin jobs: 320 ok: 298 ko:  20 fail ratio: 6.25%
    master gerrit plg jobs: 324 ok: 259 ko:  52 fail ratio:16.05%
    master gerrit win jobs: 254 ok: 219 ko:  34 fail ratio:13.39%
    master gerrit mac jobs: 251 ok: 227 ko:  18 fail ratio: 7.17%
    master gerrit all jobs: 362 ok: 199 ko:  99 fail ratio:27.35%
     + CI slow today – quite a few commits in the queue.
     + is this lots of back-ports to -6-0 (Miklos)
        + empty 6.0 queue now. (Cloph)
            + limit of 10 builds where linux can work ahead ATM

* de-modalizing Dialogs (Kendy)
    + online – with many collaborators on the same document
    + can issue the same (or even other) dialogs concurrently
    + causing stack of ::Execute() methods left & right.
    + expanded the Modal / async dialog support
    + used this mechanism with better API: lambdas
       + when Execute returns button ‘ok’ - call lambda etc.
    + can’t get stuck in Execute – so code continues further
       + mostly ok, code works fine.
       + in some cases: shared-pointer/ lambdas
    + some cases SfxRequest wants a return value
       + eg. style application – returned values – but unused
         in slot / SDI / and code apparently.
      + interested in QA feedback.
   + can we use this for Apply in modal dialogs ? (Heiko)
      + neither easier or harder (Kendy)
         + could think on extending the lamda to be multi-called
         + interested in paragraph properties (Heiko)
             + not complicated anyway to do same bits (Miklos)

* Budgeting (Thorsten)
    + collecting wish-lists:
        + get some fast new Macs and host at Manitu
        + gerrit updates
    + other ideas for development topics ?

* l10n (Sophie)
    + going nicely – people like the LibreOffice Online version
    + and also the de-fuzzing Cloph did last week.
        + happy.
    + third pass of de-fuzzing ~unclear if it is needed
        + translators have done this ~manually
        + most fuzzy strings left – fuzzy in the old (Cloph)
           + or not translated at all.
           => avoided the third round; only 200words across project.
    + gettext migration is finally complete ! …
    + have ordered a TDF server to migrate pootle back to our infra.
        + a dedicated server – not sharing the same clustered FS.
* QA update (Xisco)

    + UNCONFIRMED: 406 (+2)
        + enhancements: 46  (+6)
        + needsUXEval: 0 (+0)
        + haveBackTrace: 6 (+0)
        + needsDevAdvice: 25 (-3)
        + documentation:  2 (+0)
        + android:  8 (-1)


    + SDI slot crasher
        + tried opening many windows, or dialogs - didn’t reproduce.
        + try back-porting it to 6-0 (Xisco)
        + should we have copy/paste going on after SfxApplication death ? (Michael)

    + Most Pressing Bugs: http://tdf.io/mostressingbugs
        + New:
             + EDITING: CRASH (Reason=EXCEPTION_ACCESS_VIOLATION_READ) when paste special contents 
from particular source.ods as GDI metafile
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=114710
                   + kohei ?

             + Libreoffice crash on exit when sidebar is enabled (cf. Comment 4)
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=115023
                   + unique_ptr / Noel bisection.
          
        + Older:
             + crashing with insert subtotals in Calc
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=114720
                   + gerrit review: https://gerrit.libreoffice.org/#/c/48099/
                       + thanks to Ahmed Ghanmi

             + Crash with CJK characters in status bar (OpenGL) 
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=114736
                   + Tamas Bunth – to look at SalLayout caching ?

        + Fixed:
             + CRASH: Read-only file crashes executing the macro (steps: comment 3)
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=114932
                   + The root of the problem is an UnknownPropertyException
                   + fixed thanks to Markus.

             + Crash on layout of specific document
                   + https://bugs.documentfoundation.org/show_bug.cgi?id=114536
                   + fixed thanks to Miklos.


* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +113  +11 (-100) overall)
      many thanks to the top bug squashers:
       Xisco Faulí             20
       Heiko Tietze            15
       Aron Budea              8
       Buovjaga                7
       Julien Nabet            4
       Thorsten Behrens (CIB)  3
       Mike Kaganski           2
       Justin L                2
       robert                  2
       raal                    2

    + top 10 bugs reporters:
       Telesto                 6
       Dan Dascalescu          5
       Thomas Lendo            5
       Regina Henschel         4
       Mike Kaganski           3
       sunweb                  3
       James Harkins           2
       tim                     2
       Aron Budea              2
       Pierre C                2

    + top 10 bugs fixers:
       Tietze, Heiko           4
       Nabet, Julien           3
       Thorsten Behrens (CIB)  3
       Mehrbrodt, Samuel       2
       Kosiorek, Bartosz       2
                               1
       Xisco Faulí             1
       Faure, Jean-Baptiste    1
       Olivier Hallot          1
       Mohrhard, Markus        1

    + top 10 bugs confirmers:
       Xisco Faulí             33
       Raal                    9
       Alex Thurgood           7
       Jacques Guilleron       4
       Nabet, Julien           4
       Telesto                 3
       m.a.riosv               3
       Philips, Yousuf         3
       dieterp                 2
       Thomas Lendo            2


* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     5.3 : 2/49 -     4 %  (+0)
     5.2 : 2/40 -     5 %  (+0)
     5.1 : 1/35 -     2 %  (+0)
     5.0 : 3/63 -     4 %  (+0)
     4.4 : 2/76 -     2 %  (+0)
     4.3 : 6/75 -     8 %  (+0)
     4.2 : 6/134 -    4 %  (+0)
     4.1 : 3/84 -     3 %  (+0)
     4.0 : 4/83 -     4 %  (+0)
     old : 24/259 -   9 %  (+0)


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   + 428/1848 427/1840 418/1820 408/1805 410/1796 420/1795 413/1767 

     done by:
        Xisco Faulí            3
        Raal                   3
        Budea, Áron            2
        Telesto                1
 

* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   + 523/2468 520/2459 512/2437 499/2419 500/2409 510/2407 500/2376 

     done by:
        Xisco Faulí            3
        Raal                   3
        Budea, Áron            3
        Telesto                1


* all bugs tagged with 'regression'
   + 902(+0) bugs open of 6697(+9) total 11(+1) high prio.

     done by:
        Raal                   3
        Telesto                3
        Jacques Guilleron      2
        Xisco Faulí            1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Calc          - 3(+0)
     graphics stack - 2(+0)
     LibreOffice   - 2(+1)
     Writer        - 2(+0)
     Impress       - 2(+0)

   by OS:
     Mac OS X      - 3(+0)
     Linux         - 0(+0)
     All           - 8(+1)
     Windows       - 0(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 160(-2)
     Calc                     - 154(+1)
     Impress                  - 98(+0)
     Writer: docx filter      - 75(+1)
     LibreOffice              - 74(+2)
     UI                       - 48(-1)
     graphics stack           - 37(+0)
     Writer: perf             - 34(+1)
     Writer: doc filter       - 33(+0)
     Draw                     - 32(+0)
     Base                     - 32(-1)
     Borders                  - 29(-1)
     filters and storage      - 26(+0)
     Writer: other filter     - 25(+0)
     Crashes                  - 24(+0)
     Chart                    - 19(+0)
     BASIC                    - 16(+0)
     Printing and PDF export  - 15(+0)
     framework                - 4(+0)
     Linguistic               - 2(+0)
     Installation             - 1(+0)
     sdk                      - 1(+0)
     Extensions               - 1(+0)