Re: DesktopLOKTest::testRedlineWriter is failing

On 11/04/2017 10:44 PM, Tomáš Chvátal wrote:
> 2017-05-31 8:17 GMT+02:00 David Ostrovsky <d.ostrovsky@gmx.de 
> <mailto:d.ostrovsky@gmx.de>>:
>
>     On most recent master one test is failing here:
>
>     Test name: DesktopLOKTest::testRedlineWriter
>     equality assertion failed
>     - Expected: Insert “t”
>     - Actual  : Insert t
>
>
> Hi,
>
> It seems I am reproducing this on the stable openSUSE releases while not 
> on Tumbleweed...
>
> [ 7317s] Test name: DesktopLOKTest::testRedlineWriter
> [ 7317s] equality assertion failed
> [ 7317s] - Expected: Insert “t”
> [ 7317s] - Actual  : Insert    t
>
>
> Any ideas?

Looking at the surrounding code

>     // Get redline info.
>     boost::property_tree::ptree aTree;
>     char* pJSON = pDocument->m_pDocumentClass->getCommandValues(pDocument, 
> ".uno:AcceptTrackedChanges");
>     std::stringstream aStream(pJSON);
>     free(pJSON);
>     CPPUNIT_ASSERT(!aStream.str().empty());
>     boost::property_tree::read_json(aStream, aTree);
>     // Make sure that pressing a key creates exactly one redline.
>     CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(1), aTree.get_child("redlines").size());

what's the binary content of that "char* pJSON" stream?  If that's still 
intact, then it's apparently boost::property_tree::read_json that's 
breaking things.  And if that's already garbled, then it's apparently 
the producer side of that pDocument->m_pDocumentClass->getCommandValues 
(whatever that is) that is breaking it and needs further investigation.