Re: Minutes of ESC call 2017-09-21

On Mon, Sep 25, 2017 at 12:06:42PM +0200, Xisco Fauli wrote:
> Hello Khaled,
>
> > * Reverting ‘tdf#103831, tdf#100986: Force using GDI when needed’ for 5.3.7? (Xisco)
> >     + 
> > https://cgit.freedesktop.org/libreoffice/core/commit/?id=a51b7a1c3a7e7cf7b0c733e1dec40288278c1884
> >     + Fixes:
> >     + Horizontal Text: https://bugs.documentfoundation.org/show_bug.cgi?id=103831
> >     + Rotated Text: https://bugs.documentfoundation.org/show_bug.cgi?id=100986
> >     + Introduced:
> >     + META: https://bugs.documentfoundation.org/show_bug.cgi?id=112486 
> >     + Font rendering issue.
> >      + Khaled’s commit – can you talk to him first? (Kendy)
> > AI:      + will talk to Khaled (Xisco)
> Any objection/comment/opinion about getting this commit reverted in 5.3.7 ?

Hmm, I don’t think you need to revert the whole change. Looking into
this again, I think there are two unrelated changes in this commit;
forcing GDI for non-horizontal text which fixed the two bugs, and
optionally not using GDI when not using OpenGL (previously we always
used GDI when OpenGL was used). I think it was wishful thinking of my
part to think the non-GDI code path is usable.

In short, I guess you just need to change the !bUseOpenGL branch back to:

        DrawTextLayout(rLayout, hDC, false);

This should fix the newly introduced issues. I can’t test this myself
right now, though, and might not be able to do so for few more weeks.
It might also cause a regression for some Graphite fonts, but I
don’t remember the details, but it shouldn’t be hard to have a
CommonSalLayout::isGraphite() or so to signal such fonts and not use
GDI for them.

Regards,
Khaled