Minutes of ESC call 2017-09-21

* Present
    + Stephan, Armin, Caolán, Heiko, Miklos, Olivier, Xisco, Kendy, Eike,
      Christian, Sophie, Jan-Marek, Michael S

* Completed Action Items:
    + Added ‘top 10 bugs confirmers’ to the esc minutes (Xisco)

* Pending Action Items:
    + fix scripts producing junk numbers for crash testing (7 and 7) (Shinnok)
        [ pending – making the scripts work again. ]
    + fwd build details on Mac / CVE build / test failure to the list (Shinnok)
        [ still working on this, hope to have it done today ]
    + research the best way to build HTML help / documentation (Olivier)
        [ still working on this ]
    + look at breakpad symbol issue for crash-reporting (Christian)
        [ symbols look correct, trying to upgrade breakpad, maybe size limitation?
          Still investigating ]

* Release Engineering update (Christian)
    + 5.4.2 RC2 status
        + available for download 
    + 5.3.7 - 1st week of October as initially scheduled     
    + 6.0 Alpha1 – moved to after the conference
        + 1 week after the conference
    + Android
        + debugging a crash
        + problem with freetype
            + probably not a new problem? (Miklos)
            + crashes even with an example document from the About dialog (Cloph)
                + which used to work (Cloph)
    + Online - RC2

* Documentation (Olivier)
    + More help pages updates (Olivier)
        + terminology, new dialog pages
    + Helponline:
        + script tweaks
        + Added more languages support in UI and Custom Search
        + Pro package
            + Help is an essential part of the software (htieze)
            + Security concerns on extension installation in corp env.
            + Extension website “not nice”
            + preserve current download + donation process
        + Pro extension
            + technically easy
            + can loose donation will from users
        => keep MSI as the package on Windows, and other platform’s packaging too
     + Books and literature
         + Guide 6.0 on going

* UX Update (Heiko)
  + Bugzilla (topicUI) statistics
        254(254) (topicUI) bugs open, 407(407) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week    1 month   3 months   12 months   
             added      5(-1)     20(2)     33(-1)     126(-4)  
         commented     47(-39)   220(-2)   533(-4)    2800(-127)
           removed      1(0)       2(1)      5(0)       33(-7)  
          resolved      3(-3)     17(-4)    68(-4)     282(-7)  
    + top 10 contributors:
          Tietze, Heiko made 114 changes in 1 month, and 1470 changes in 1 year
          Thomas Lendo made 66 changes in 1 month, and 464 changes in 1 year
          Philips, Yousuf made 50 changes in 1 month, and 1283 changes in 1 year
          Faulí Tarazona, Xisco made 45 changes in 1 month, and 446 changes in 1 y
          Foote, V Stuart made 42 changes in 1 month, and 512 changes in 1 year
          Buovjaga made 34 changes in 1 month, and 350 changes in 1 year
          Adolfo Jayme Barrientos made 22 changes in 1 month, and 70 changes in 1 y
          Dieter Praas made 19 changes in 1 month, and 54 changes in 1 year
          Cor Nouws made 19 changes in 1 month, and 286 changes in 1 year
          Ionita, Teodor-Mircea made 13 changes in 1 month, and 13 changes in 1 y
   * HIG draft for selections “Use controls for selection depending on content.”
      + https://wiki.documentfoundation.org/Design/Selection 
      + please review esp. actions

* CrashHunting (Caolan)
    + 2 import failures, 0 export failures
        + fixed a lot the last week
    + 7 coverity issues
    + Google / ossfuzz: 33 fuzzers active now
        - fodt and fods newly added
        - mostly leaks when exceptions thrown

* Crash Reporter (Xisco)
    + http://crashreport.libreoffice.org/stats/?days=128
    + http://crashreport.libreoffice.org/stats/version/5.3.6.1
        + 896 (last 7 days)
    + http://crashreport.libreoffice.org/stats/version/5.4.0.3
        + 4998 (last 7 days)
    + http://crashreport.libreoffice.org/stats/version/5.4.1.2
        + 2666 (last 7 days)
          + Most reported bug ( apart from mergedlo.dll) fixed.
    + breakpad debuginfo / dumping issue cf. Markus’ list post

* Hackfests & Events (Bubli)
    + new plan from Bjoern:
       + https://skyfromme.wordpress.com/2017/08/27/hackfests-the-next-generation/
         + another kickoff call September 17th at 14:30 UTC  for planning.
    + LibreOffice Conference
         + hacknight on Thu evening (Sophie)
    + had a phone call, plan is to have a Hackfest in Hamburg (Eike)
    + Hamburg – 1st new-style hackfest
         + 9th - 10th December
         + just after feature freeze / branch-off / Beta1
         + https://wiki.documentfoundation.org/Hackfests/HackfestTNG (Eike)
    + FOSDEM
         + beginning of February
    + Milano? - or somewhere else in Italy - 2nd new-style hackfest
         + in March 

* mentoring/easyhack update (Shinnok)
          committer...   1 week     1 month     3 months    12 months   
                  open      54(-2)     103(-7)     105(-20)     113(-20)
               reviews     581(32)    2068(80)    5320(175)   17401(203)
                merged     233(24)     859(50)    2658(24)    10703(77) 
             abandoned      12(-13)     76(-3)     262(4)       680(0)  
           own commits     316(80)    1129(109)   1830(280)   14063(5)  
        review commits      58(-9)     305(-21)    509(54)     2809(-49)
        contributor...   1 week     1 month     3 months   12 months   
                  open      13(-3)      34(-3)      37(-4)      40(-3) 
               reviews     718(-38)   2595(28)    6521(62)   21555(202)
                merged      25(-1)     140(-25)    362(-5)    1331(16) 
             abandoned       6(-11)     43(4)       87(3)      281(5)  
           own commits      23(-3)     139(-27)    263(17)     985(14) 
        review commits       0(0)        0(0)        0(0)        0(0)  
    + easyHack statistics:
       needsDevEval 25(25)   needsUXEval 0(0)   cleanup_comments 195(195)   
       total 247(247)   assigned 7(7)   open 213(213)   
    + top 5 contributors:
          Gelmini, Andrea made 27 patches in 1 month, and 148 patches in 1 year
          Kainz, Andreas made 14 patches in 1 month, and 61 patches in 1 year
          Carl, Jens made 12 patches in 1 month, and 103 patches in 1 year
          Andreas Brandner made 9 patches in 1 month, and 9 patches in 1 year
          Grzegorz Araminowicz made 7 patches in 1 month, and 13 patches in 1 year
    + top 5 reviewers:
          Pootle bot made 302 review comments in 1 month, and 387 in 1 year
          Stahl, Michael made 220 review comments in 1 month, and 1806 in 1 year
          Behrens, Thorsten made 210 review comments in 1 month, and 727 in 1 year
          Mohrhard, Markus made 152 review comments in 1 month, and 1294 in 1 year
          Grandin, Noel made 151 review comments in 1 month, and 1299 in 1 year
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Sabin Frandes sabin.frandes@cib.de 
          Yash Srivastav yash111998@gmail.com 
          Jean-Sebastien Bevilacqua jsbevilacqua@linagora.com 

* Commit Access
    + propose Andreas Kainz (Kendy)
         => enable in gerrit

* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
    + sleeping for 2 weeks

* Jenkins / CI update (Christian)
    from:Thu Sep 14 16:19:05 2017
    master linux rel  jobs: 180 ok: 169 ko:   9 fail ratio:  5.00 % break:   1 broken duration: 
1.32%
    master linux dbg  jobs: 123 ok: 116 ko:   5 fail ratio:  4.07 % break:   2 broken duration: 
1.07%
    master mac rel    jobs: 113 ok: 109 ko:   3 fail ratio:  2.65 % break:   3 broken duration: 
1.97%
    master mac dbg    jobs: 119 ok: 114 ko:   3 fail ratio:  2.52 % break:   3 broken duration: 
1.35%
    master win rel    jobs: 124 ok:  96 ko:  28 fail ratio: 22.58 % break:  16 broken 
duration:19.44%
    master win dbg    jobs: 124 ok: 105 ko:  19 fail ratio: 15.32 % break:  14 broken 
duration:10.90%
    master win64 dbg  jobs: 140 ok: 125 ko:  15 fail ratio: 10.71 % break:  11 broken duration: 
6.18%
    lo-5.3 mac        jobs:   7 ok:   3 ko:   4 fail ratio: 57.14 % break:   2 broken 
duration:10.05%
    lo-5.4 mac        jobs:   0 ok:   0 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    branch gerrit all jobs:   0 ok:   0 ko:   0 fail ratio: 0.00%
    master gerrit lin jobs: 387 ok: 338 ko:  34 fail ratio: 8.79%
    master gerrit plg jobs: 387 ok: 292 ko:  82 fail ratio:21.19%
    master gerrit win jobs: 397 ok: 319 ko:  66 fail ratio:16.62%
    master gerrit mac jobs: 396 ok: 271 ko:  86 fail ratio:21.72%
    master gerrit all jobs: 399 ok: 204 ko: 153 fail ratio:38.35%
    + queue grew large due to a unit test problem
    + please don’t rebase again and again when your build did not finish!!! (Cloph)
        + can make the situation much worse…
    + can we get a better warning / feedback than killing the build? (Heiko)
        + hard in an emergency situation like this (Cloph)
        + we’d need Norbert to help with this (Stephan)

* Switch Gerrit Jenkins (master) builds from Windows x86 to x86_64? (Stephan)
    + would e.g. have found adbf7da7d1d9a1701c3fccbfbbf9d749d6478e6c
      “Inconsistent declarations of ImplSalYieldMutexAcquireWithWait” earlier
    + I had assumed that we generally promote Windows x86_64 instead of x86,
      surprised to see <http://www.libreoffice.org/download/download/> still
      offer x86 as default?
        + is that intentional? (Stephan)
    + isn’t the download chosen by browser? (Jan-Marek)
        + not on Windows – defaults for 32bit (Stephan)

    + for the jenkins, it is a matter of changing the lode configuration (Cloph)

    + wrt. Download – should we still default to 32bit? (Stephan)
        + website defaults to that (Cloph)
        + the browsers don’t indicate 64bit on Windows (Cloph)
        + we can change the default if we think that majority of users is on 64bit
          windows now (Cloph)
        + should we change the default when the info is not provided? (Jan-Marek)
AI:         + can switch that for pre-release version, and see what’s the
              feedback (Cloph)

* l10n (Sophie)
    + LibreOffice 5.4 was split in pootle, but master project not updated
      yet (Cloph)

* Reverting ‘tdf#103831, tdf#100986: Force using GDI when needed’ for 5.3.7? (Xisco)
    + 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=a51b7a1c3a7e7cf7b0c733e1dec40288278c1884
    + Fixes:
        + Horizontal Text: https://bugs.documentfoundation.org/show_bug.cgi?id=103831
        + Rotated Text: https://bugs.documentfoundation.org/show_bug.cgi?id=100986
    + Introduced:
        + META: https://bugs.documentfoundation.org/show_bug.cgi?id=112486 
        + Font rendering issue.
     + Khaled’s commit – can you talk to him first? (Kendy)
AI:      + will talk to Khaled (Xisco)

* QA update (Xisco)

     + UNCONFIRMED: 411 (+21)
        + enhancements: 49  (+5)
        + needsUXEval: 1 (+0)
        + haveBackTrace: 9 (+0)
        + needsDevAdvice: 35 (+2)
        + documentation:  4 (+2)
        + android:  25 (+0)
    + Most Pressing Bugs: http://tdf.io/mostressingbugs
        + New:
            + libreoffice from 5-4 branch shows a broken helpimg icon theme in options.
                    + https://bugs.documentfoundation.org/show_bug.cgi?id=108406
                    + upstreams debs hang when trying to open Tools→Options→View
                    + Patch in gerrit: https://gerrit.libreoffice.org/#/c/42545/

        + Older:
            + FILESAVE: LibreOffice is stuck while saving (MACOS)
                + https://bugs.documentfoundation.org/show_bug.cgi?id=112288
                + Jmux ?
                + already had a look at it, and don’t see it.
                    + waiting for monotonic ticks to go in.

        + Fixed:
            <none>

* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +146  -28 (-108) overall)
      many thanks to the top bug squashers:
       Xisco Faulí             14
       V Stuart Foote          7
       Yousuf Philips (jay)    6
       Julien Nabet            6
       Tamás Zolnai            5
       Heiko Tietze            5
       Telesto                 5
       Alex Thurgood           4
       Timur                   3
       raal                    3

    + top 10 bugs reporters:
       Telesto                 10
       Yousuf Philips (jay)    8
       Emil Tanev              8
       Oliver Sander           5
       Gabor Kelemen           5
       Thomas Lendo            4
       Samuel Mehrbrodt (CIB)  3
       Aron Budea              3
       robert                  2
       Mert Tumer              2

    + top 10 bugs fixers:
       Zolnai, Tamás           5
       Faulí Tarazona, Xisco   3
       Nabet, Julien           3
       McNamara, Caolán        2
       Kaganski, Mike          2
       Philips, Yousuf         2
       Kara, Muhammet          2
       Stahl, Michael          2
       Le Grand, Armin         2
       Behrens, Thorsten       2

    + top 10 bugs confirmers:
       Faulí Tarazona, Xisco   27
       Raal                    9
       Philips, Yousuf         8
       Alex Thurgood           7
       Dieter Praas            6
       Thomas Lendo            6
       Nabet, Julien           6
       Jacques Guilleron       4
       m.a.riosv               3
       Budea, Áron             3


* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     5.3 : 1/45 -     2 %  (+0)
     5.2 : 2/38 -     5 %  (+0)
     5.1 : 1/34 -     2 %  (+0)
     5.0 : 2/61 -     3 %  (+0)
     4.4 : 3/76 -     3 %  (+0)
     4.3 : 6/74 -     8 %  (+0)
     4.2 : 6/134 -    4 %  (+0)
     4.1 : 3/83 -     3 %  (+0)
     4.0 : 4/83 -     4 %  (+0)
     old : 27/258 -   10 %  (+0)


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   + 371/1593 369/1583 372/1569 375/1557 381/1551 377/1541 383/1533 

     done by:
        Faulí Tarazona, Xisco   7
        Terrence Enger          1
        Raal                    1
        Kaganski, Mike          1
        Budea, Áron             1
 

* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   + 451/2191 461/2191 461/2173 466/2159 477/2152 471/2139 476/2129 

     done by:
        Faulí Tarazona, Xisco   6
        Raal                    1
        Kaganski, Mike          1
        Budea, Áron             1


* all bugs tagged with 'regression'
   + 867(-5) bugs open of 6346(+10) total 6(-1) high prio.

     done by:
        Faulí Tarazona, Xisco      3
        Henschel, Regina           1
        robert                     1
        Philips, Yousuf            1
        Alex Thurgood              1
        Balland-Poirier, Laurent   1
        Buovjaga                   1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer        - 2(+0)
     Impress       - 2(+0)
     LibreOffice   - 2(+0)
     Calc          - 0(-1)

   by OS:
     Mac OS X      - 4(+0)
     All           - 2(+0)
     Windows       - 0(-1)
     Linux         - 0(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 151(+0)
     Calc                     - 135(-4)
     Impress                  - 83(+1)
     Writer: docx filter      - 72(+1)
     LibreOffice              - 69(-3)
     UI                       - 51(+0)
     graphics stack           - 38(+1)
     Writer: doc filter       - 36(-1)
     Draw                     - 34(-1)
     Writer: perf             - 31(-1)
     Base                     - 31(+1)
     Borders                  - 30(+0)
     Writer: other filter     - 26(+0)
     filters and storage      - 23(+0)
     Chart                    - 21(+1)
     BASIC                    - 16(+0)
     Printing and PDF export  - 16(+0)
     Crashes                  - 13(-1)
     framework                - 4(+0)
     Installation             - 3(+0)
     Extensions               - 2(+0)
     Linguistic               - 2(+0)
     sdk                      - 1(+0)