Date: prev next · Thread: first prev next last
2017 Archives by date, by thread · List index


Hi Mohammed,

On 06/06/17 13:07, Mohammed Abdul Azeem wrote:
            Now I read it again, I'm rather skeptical that:

    +        if( !maUsedBuffers.empty() )
...
            is helpful. I'm not sure that we can re-use these buffers
    efficiently
    here - perhaps its better just to allocate new ones in the stream read
    method; can you profile with and without that (would love to get rid of
    the extra complexity if possible).

Here you go.

with UsedBuffers:
https://demo.collaboracloudsuite.com/tdf/index.php/s/Hbsp5rI8FE7CHmF
without
UsedBuffers: https://demo.collaboracloudsuite.com/tdf/index.php/s/PIcWD261zVcwpWj

        Interesting =) well it seems to save a small amount of time - which is
surprising; the uno_type_sequence_reference2One seems to take rather a
long time - I imagine we could be more careful there.

        Anyhow - thanks for poking at it,

        ATB,

                Michael.

-- 
michael.meeks@collabora.com <><, Pseudo Engineer, itinerant idiot

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.