Re: a few more comments ...

Hi Mohammed,

On 06/06/17 13:07, Mohammed Abdul Azeem wrote:
>             Now I read it again, I'm rather skeptical that:
>
>     +        if( !maUsedBuffers.empty() )
...
>             is helpful. I'm not sure that we can re-use these buffers
>     efficiently
>     here - perhaps its better just to allocate new ones in the stream read
>     method; can you profile with and without that (would love to get rid of
>     the extra complexity if possible).
>
> Here you go.
>
> with UsedBuffers:
> https://demo.collaboracloudsuite.com/tdf/index.php/s/Hbsp5rI8FE7CHmF
> without
> UsedBuffers: https://demo.collaboracloudsuite.com/tdf/index.php/s/PIcWD261zVcwpWj

        Interesting =) well it seems to save a small amount of time - which is
surprising; the uno_type_sequence_reference2One seems to take rather a
long time - I imagine we could be more careful there.

        Anyhow - thanks for poking at it,

        ATB,

                Michael.

-- 
michael.meeks@collabora.com <><, Pseudo Engineer, itinerant idiot