Minutes of ESC call: 2017-03-02

* Present:
        + Stephan, Sophie, Norbert, Christian, Thorsten, Michael S, Michael M, Stefan W.Caolan, 
Heiko,
           Kendy, JanI, Olivier, Thorsten, Xisco, Bjoern, Miklos, Bubli

* Completed Action Items:

* Pending Action Items:
    + collect names of Perugia / Hackfest interested mentors in a wiki page (Bjoern)

* Release Engineering update (Christian)
    + 5.2.6 RC2
               + taggedd & build and on pre-release server
         + 5.3.1 RC2
               + two patches waiting in the queue, branch is prepared
               + translations updated yesterday.
               + https://gerrit.libreoffice.org/#/q/status:open+branch:libreoffice-5-3-1
        + final release shifted one week.
    + Android & iOS Remote
    + online (Michael)
      + 5.3.1.2 release up-loaded by Timar - Monday.
             + happy with that RC2 if it's done (Thorsten)

* Online (Michael)
    + entirely new socket code – big, disruptive feature:
        + completely re-written: non-blocking, not threaded for 5.4
            + lets see how it hangs out - next time.
    + concerns around -5-3
                  + concerned about the quality of that -> that's why we have gerrit review
                  + no users -> no bugs -> no fiixes -> working on providing all three of it
                  + good to have CIB working on it.
                  + concerned wrt. UI freeze / feature breakage there - and core effects too.
         + couple to look at:
                     + https://gerrit.libreoffice.org/#/c/34793/1
                     + https://bugs.documentfoundation.org/show_bug.cgi?id=106273
                     +  tdf#106273 Various performance/stability fixes
                     + merges 20+ commits (seems mostly fixes, with a few improvements sneaked in)
                             + PNG cache / hash feature
                             + vector -> dequeu converion
                             + exeption handling / tile combining change + revert
                             + writer part fixes
                             + tile queue change.
                             + improved MessageQueue & its revert.
                             + commiitted under Samuel's name - tons of Collabora work.
                             +  if a feature / disruptive - shouldn't merge (Thorsten)
                                  + good to have it maintained though.
                     + https://gerrit.libreoffice.org/34791
                            + tdf#106276 loleaflet: notify repair document when exists a conflict 
of ...
                            + can't work without core changes -> missing Henry's patch to core
                                 + changes an UNO command -> return values.
                            + adds a new dialog with a new string.
                            + don't know it belongs on the -5-3 branch.
                                 + at least not without the core changes (Thorsten)
                                     + a challenge to sync core & online changes, we need to come 
up with a sustainable plan there anyway
                                     + perhaps a SHA1 in online referencing a core version, ala 
submodules?
                     + would love a normal approach here (Michael)
                         + agreed same rules should apply to both core and online (Thorsten)
                         + core rules around review: 
                     + new features:
                         + 2 approves from different companies + 3 reviews.
                         + can't count author of patch as one approver if they didn't approve it 
(Michael)
                         + same rules apply to both online and core (Thorsten)
                             + Andras patches to -5-3 with sign-off, without gerrit.
                                 + that's the current practice for fixes (Michael)
                         + stable branch for fixes (Norbert)
                             + distinction for stable branch on core or anything else.
                                  + diversity with some company involved is helpful.
                         + core - some ACLs - can't push direct on release branch (Norbert)
                             + want test builds on Jenkins (Michael S)
                                  + doesn't apply to online repo.
                             + in principle - things should be reviewed on stable (Norbert)
                                 + Andras reviewing those.
                    + should we accept can't treat someone's authorship as a review for 
back-porting  ?
                        + online should be treated as core for stable branch.
                        + if that patch was for core - would we accept & worry about it.
                 => don't count original authorship as one of two corporate 'review for a branch'.

* Bump master baseline from MSVC 2013 to 2015? (Stephan)
    + ok with bumping base-line for 5.4 (Cloph)
    => re-visit next week with more data from Norbert.
            + are we happy switching the bots ?
                + did install Visual Studio 2015 - on bots we have.
                + once was able to upgrade the Pro version to SP3 - but on another box had issues.
                + they all have a Visual Studio 2015 now.
         + compatibility with WinXP options (Norbert)
               + should we drop XP and switch to 64bit.
               + these are independent decisions (Stephan)
               + lets de-couple these decisions (Michael)
         => can encourage David to push commit series to raise base-line to 2015.
                + with our thanks
                + good stuff (Thorsten)
        + do any tinderboxes need updating ? (Stephan)
              + Thorsten + Cloph.
        + can we remove support initially in a small commit ? (Michael)
              + did lots of builds before this (Norbert)
                   + don't expect it will break any CI.
                   + this helps rid us of duplicate pythons
              + constexpr commits coming from me (Stephan)
        + stable branch is VS 2013 - careful of backports (Norbert)
             + community edition IDE can't be used until you register
                 + E-mail + Account on MS stuff...
                 + only blocks the IDE, not compiler.
             + was some registration needed in the build ? (Stephan)
                 + some project or makefile conversion (Thorsten)
                     + someone claimed it was a red herring.

* Documentation (Olivier)
     + Published Getting started 5.2 
          + http://documentation.libreoffice.org
          + Ajusted template to export to XHTML, read-online
          + Adjusted pages for download
     + Patch for TDF#105831 (donate entry in help menu)
          + https://gerrit.libreoffice.org/#/c/34693/
     + Help online 3
                    + waiting for pootle to be adjusted in / infra to apply scripts.
                    + patches waiting until pootle back in our infra (Cloph)
                          + changing the meta-data
                          + some conversions missing - bypassing django-based DB.
                          + once that is done - we can move back to our infra.
                          + will do seperation of libreoffice-5-3 projects.
                          + pootle currently on translate.za's AWS server.
                    + waiting for Dwayne to mail him saying its done (Cloph)
                          + same script - used for FOSDEM migration; but are writing an 
auto-validator.

* UX Update (Heiko)
   + Bugzilla (topicUI) statistics
       251(251) (topicUI) bugs open, 477(477) (needsUXEval) needs to be evaluated by the UXteam
   + Updates:
       BZ changes   1 week    1 month   3 months   12 months  
            added      2(-3)     12(-3)    34(-4)     496(1)  
        commented     24(-31)   217(-5)   716(-13)   3695(-10)
          removed      1(0)       2(1)      8(1)       38(0)  
         resolved      2(-4)     46(0)     97(-5)     197(2)  
   + top 10 contributors:
         Faulí Tarazona, Xisco made 162 changes in 1 month, and 371 changes in 1 year
         Tietze, Heiko made 133 changes in 1 month, and 2144 changes in 1 year
         Foote, V Stuart made 41 changes in 1 month, and 677 changes in 1 year
         Cor Nouws made 36 changes in 1 month, and 493 changes in 1 year
         Philips, Yousuf made 30 changes in 1 month, and 1502 changes in 1 year
         Thomas Lendo made 29 changes in 1 month, and 32 changes in 1 year
         Buovjaga made 26 changes in 1 month, and 352 changes in 1 year
         Kainz, Andreas made 14 changes in 1 month, and 15 changes in 1 year
         *UNKNOWN* made 9 changes in 1 month, and 16 changes in 1 year
         LibreTraining made 9 changes in 1 month, and 9 changes in 1 year
   + Minimum screen size: WXGA 1280x768
                + (changed from http://www.libreoffice.org/get-help/system-requirements/ )
                     + some complaints inevitable but ? ...
                     + vertical size more important than width (Michael)
                          + still 768 pixels.
                          + depends on system theme - with large menu item padding - so scroll up 
and down.
      + Planning a survey about table styles to update the implemented versions with the proposals 
from last year
           + work is planned to change the styles.
      + Publisher.ch referenced the freecolor-hlc palette
           + Swiss journal announced - available as a hard color fan / physical print-out.
                  + also in our product - LibreOffice only one for pro. printing in Open Source.

* Crashtest update (Caolan)
    + 0 import failure, 2 export failures
              + down to almost nothing again.
    + 169 coverity issues.
              + down slightly, but still high.
    + Google / ossfuzz: 22 fuzzers active now
              + LWP recently added, next is PPT.

* Hackfests (Bjoern)
    + next venues / suggestions
    + Ladies who FOSS – sometime in March (Bubli)
        + organized in Berlin.
        + monthly now, 16th March the next time (Bubli)
            + unfortunately during a working day
        + April 20th the next one
    + Italian hack-fest coming up: 4 days May 27-30th
         + Perugia University
         + ...
    + event in Spain (Xisco)
        + will be in Malaga for Open conference in May
            + http://www.opensouthcode.org/conference/opensouthcode2017
        + an idea to do something.
        + Xisco giving a talk there too - be good to meet up.
    + UX people: Arnaud suggested a UX meeting (Heiko)
        + perhaps in Corsica; acknowledged - UX people.
           + like the idea
        + love to have some devs there too (Michael)
        + have a topic focus on UX.
    + Essen meeting (Bjoern)
        + suggestions for bike-shedding topics to get people interesting
            + UX / Extensions ?
        + suggested dates in April 15th or 23rd German community coming up with that.
        + not nailed down yet
    + another hackfest in Spain for Document Freedom Day (Xisco)
        + in Granada, will have more info shortly (Xisco)
        + worth talking to Italo to do some PR - it is close (Bjoern)
        + do you need VM's? (Bjoern)
            + will talk to Cloph if yes (Xisco)
 
* mentoring/easyhack update (JanI)
   + openhub statistics (2017-02-10), 277(277) people did 15401(15401) commits in 12 month in 
8804167(8804167) lines of code
   + gerrit/git statistics:
         committer...   1 week     1 month      3 months    12 months   
                 open      49(-18)     93(-10)     102(-7)      109(-6) 
              reviews     429(15)    1583(-106)   4363(-16)   17252(-15)
               merged     195(-2)     898(-18)    2747(-95)    9929(77) 
            abandoned      12(-2)      56(-1)      138(-6)      660(-5) 
          own commits     354(-90)   1652(18)     3135(22)    17328(-46)
       review commits      31(-25)    209(-4)      425(-33)    3321(-24)
       contributor...   1 week     1 month     3 months     12 months   
                 open      18(7)       40(-1)      49(5)         49(5)  
              reviews     497(-31)   2050(-39)   5272(-156)   18673(92) 
               merged       6(-16)     75(-5)     200(-2)       786(-9) 
            abandoned       4(-1)      23(0)       81(-2)       270(-4) 
          own commits       5(-18)     76(-7)     120(-3)       755(-11)
       review commits       0(0)        0(0)        0(0)          0(0)  
   + easyHack statistics:
      needsDevEval 23(23)   needsUXEval 0(0)   cleanup_comments 188(188)   
      total 229(229)   assigned 26(26)   open 178(178)   
   + received patches from 0 emails the last month without licesense statement
   + top 5 contributors:
         Johnny_M made 8 patches in 1 month, and 13 patches in 1 year
         Prajapati Gautam made 6 patches in 1 month, and 6 patches in 1 year
         Röllin Lukas made 5 patches in 1 month, and 5 patches in 1 year
         Dumas, Arnold made 5 patches in 1 month, and 26 patches in 1 year
         Donkers, Winfried made 5 patches in 1 month, and 52 patches in 1 year
   + top 5 reviewers:
         Iversen, Jan made 178 review comments in 1 month, and 1527 in 1 year
         Stahl, Michael made 147 review comments in 1 month, and 1098 in 1 year
         Vajna, Miklos made 129 review comments in 1 month, and 1160 in 1 year
         Mohrhard, Markus made 123 review comments in 1 month, and 1831 in 1 year
         McNamara, Caolán made 107 review comments in 1 month, and 1466 in 1 year
   + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
        NONE

        + warning signal: no new license staements in 2 weeks, and very low
        patch actvity

* GsoC update (Thorsten)
    + we're accepted!
         + awesome!
    + please point that out to students if you know any (Thorsten)
    + sign up as mentors please! (Thorsten)
AI:      + org admins to invite listed mentors (once gsoc page bug is fixed) (Thorsten)
    + multiple things tweaked in the program at the same time by Google - interesting to see how it 
pans out this year(Thorsten)
    + advertising tweet from LibreOffice? (Miklos)
AI:      + would be good to have one, will look into that (Thorsten)
    + timeline:
         + now - March 20: spread the news, attract students
         + March 20 - April 3 16:00 UTC: student submissions
         + April 3 - 16: review proposals
         + April 17, 16:00 UTC: deadline to submit slot requests
         + April 19, 16:00 UTC: slot allocations announced
         + April 19 - 24 16:00 UTC: choose proposals, assign mentors
         + May 4 - 29: projects public, community bonding period starts
         + May 29: last day to report inactive students
         + May 30: coding begins
         + June 26-30: first eval
         + July 24 - second eval
         + August 21- 29: pens down, wrap up
         + August 29 - September 5: final evaluations of students
         + September 6: passing projects announced

* crash reporter news (?)
    + http://crashreport.libreoffice.org/stats/version/5.3.0.3
    + http://crashreport.libreoffice.org/stats/version/5.2.5.1
    + 5.2.4.2 – still plaguing us.
         + long tail expected.

    + for comparison, had a look at what's in Ubuntu's crash reporter (Bjoern)
    + Ubuntu top 20 occurrences last month in libreoffce counts:
      22, 18, 17, 17, 16, 14, 9, 8, 7, 6, 6, 6, 5, 5, 4, 4, 4, 4, 4, 4
    + for comparision, top 20 occurances Ubuntu-wide counts:
      8565, 3217, 562, 512, 459, 454, 425, 418, 323, 295, 288, 284, 282, 257, 249, 235, 198, 198, 
195, 184
    + Of the top 20 libreoffice occurance counts: different stacktraces(occurence count for 
1+occurence count for 2+...=total occurance count)
      + not usable: 8 (22+18+14+8+6+5+4+4=81)
      + rarely seen after: 5.2.x 5 (17+7+6+6+4=40)
      + 5.1.x 3 (17+16+4=37)
      + 4.3.x 1 (4=4)
      + 4.2.x 1 (9=9)
      + 3.5.x 2 (5+4=9)
      => so 40 out of 99 crashes = 40% of all crashers seem to be in master still

    + improved quite a bit (Bjoern)

* Commit Access

* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
    + web page is now updated (Stephan)
         + turns out there is a duplicate page which was out of date.
  * https://www.documentfoundation.org/gethelp/developers/
  * https://www.libreoffice.org/get-help/professional-support/

    + 7 week sleep.

* Jenkins / CI update (Norbert)
    + usual week
 from:Thu Feb 23 15:56:05 2017
    master linux rel  jobs: 239 ok: 226 ko:  13 fail ratio:  5.44 % break:   7 broken duration: 
7.93%
    master linux dbg  jobs: 186 ok: 180 ko:   5 fail ratio:  2.69 % break:   2 broken duration: 
3.21%
    master mac rel    jobs: 208 ok: 198 ko:  10 fail ratio:  4.81 % break:   7 broken duration: 
3.91%
    master mac dbg    jobs: 200 ok: 191 ko:   9 fail ratio:  4.50 % break:   7 broken duration: 
4.27%
    master win rel    jobs: 152 ok: 135 ko:  16 fail ratio: 10.53 % break:  11 broken duration: 
7.80%
    master win dbg    jobs: 149 ok: 135 ko:  13 fail ratio:  8.72 % break:   9 broken duration: 
6.32%
    master win64 dbg  jobs: 155 ok: 141 ko:  13 fail ratio:  8.39 % break:   8 broken duration: 
7.00%
    lo-5.2 mac        jobs:  15 ok:  15 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    lo-5.3 mac        jobs:  24 ok:  24 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 
0.00%
    branch gerrit all jobs:  19 ok:  14 ko:   4 fail ratio:21.05%
    master gerrit lin jobs: 307 ok: 275 ko:  31 fail ratio:10.10%
    master gerrit plg jobs: 306 ok: 253 ko:  51 fail ratio:16.67%
    master gerrit win jobs: 305 ok: 205 ko:  96 fail ratio:31.48%
    master gerrit mac jobs: 306 ok: 249 ko:  50 fail ratio:16.34%
    master gerrit all jobs: 307 ok: 173 ko: 127 fail ratio:41.37%

* l10n (Sophie)
    + documented TestLink instance which have several languages available (Sophie)
        + will be ready for the l10n community in ~2weeks
        + https://wiki.documentfoundation.org/TestLink

* QA update (Xisco)

    + UNCONFIRMED: 468 (+11)
        + enhancements: 35  (+2)
        + needsUXEval: 0 (0)
        + haveBackTrace: 12 (0)
        + needsDevAdvice: 45 (+9)
        + documentation:  5 (+1)
 
    + went through the crashers, and tweaked the severity of the ones that looked important (Xisco)
        + even though reported some time ago

    + Xisco provided a list of bugs with no unittest (Sophie)

    + Most Pressing Bugs: http://tdf.io/mostressingbugs
        + New:

            + FORMATTING: When undo and redo, custom styles and formatting lost, or full crash.
                    + https://bugs.documentfoundation.org/show_bug.cgi?id=88555
                    + Bubli ?
            + Comparing two files makes LibreOffice crash
                    + https://bugs.documentfoundation.org/show_bug.cgi?id=98202
                    + very old issue from 3.3.x (!)
            + Crash when saving a particular document as DOCX
                    + https://bugs.documentfoundation.org/show_bug.cgi?id=101178
                    + Synerzip issue
            + Crash in: SwWrtShell::CalcAndSetScal - in Writer paste table from Calc multiple times 
using autocaption
                    + https://bugs.documentfoundation.org/show_bug.cgi?id=102286
                    + not bisected
            + Crash in Calc when selecting "Uniform Integer" with an max value "100000000000000" in 
"Random Number Generator
                    + https://bugs.documentfoundation.org/show_bug.cgi?id=104117
                    + Kohei looking at it
                    + Tomaž Vajngerl submitted a patch: 23672df737258391bd9533e61733c6cc70b9a5eb
            + FILEOPEN: Crash of LibreOffice Calc when activating macros
                    + https://bugs.documentfoundation.org/show_bug.cgi?id=104383
                    + Kohei ?

      + Fixed:
            + Writer crashed while adding a word to the standard dictionary
                    + https://bugs.documentfoundation.org/show_bug.cgi?id=106123
                    + thanks to Caolan for fixing.
             + Left clicking after right clicking on Comments in Navigator crashes LO
                        + https://bugs.documentfoundation.org/show_bug.cgi?id=106159
                        + thanks to Caolan
 
* QA stats
  + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
    +117    -182        (-65 overall)
    many thanks to the top bug squashers:
        QA Administrators     83
        Xisco Faulí           18
        Khaled Hosny           7
        Julien Nabet           6
        V Stuart Foote         6
        Aron Budea             5
        m.a.riosv              5
        Buovjaga               4
        Justin L               4
        Winfried Donkers       4
        Mark Hung              3
        Luis                   3
        Miklos Vajna           3
        Caolán McNamara        3
        Heiko Tietze           3

  + top 10 bugs reporters:
        Kant, Pranav               4
        Balland-Poirier, Laurent   4
        Kainz, Andreas             4
        Kelemen, Gabor             3
        sergio.callegari           3
        jan d                      2
        McNamara, Caolán           2
        Tietze, Heiko              2
        Philips, Yousuf            2
        Amin, Fakabbir             2

  + top 10 bugs fixers:
        Donkers, Winfried       4
        Faulí Tarazona, Xisco   3
        Tietze, Heiko           3
        Kaganski, Mike          3
        Kłos, Szymon            3
        McNamara, Caolán        2
        Henschel, Regina        2
        Vajna, Miklos           2
        Justin L                2
        Nabet, Julien           1

* Highest-Priority bugs (aka "MABs"):
        5.3: 2/31   -  6% (+0)
        5.2: 3/28   - 10% (+0)
        5.1: 2/34   -  5% (+0)
        5.0: 3/58   -  5% (+1)
        4.4: 6/74   -  8% (+3)
        4.3: 5/72   -  6% (+0)
        4.2: 6/132  -  4% (+0)
        4.1: 4/80   -  5% (+1)
        4.0: 4/81   -  4% (+0)
        old: 29/253 - 11% (+1)
            + http://bit.ly/2lJAAJI

* Bisected bugs open: keyword 'bisected'
    + more accurate - down to a single commit.
    + 352/1284 354/1270 352/1255 350/1239 342/1220 339/1211 338/1196
                + http://bit.ly/2dyIfDy

    + Done by:
        Faulí Tarazona, Xisco   8
        Budea, Áron             4
        Jean-Baptiste Faure     1

* Bibisected bugs open: keyword 'bibisected'
    + 420/1826 423/1814 419/1797 419/1782 411/1761 410/1754 410/1737
        + http://bit.ly/2cSCXlS
 
    + Done by:
        Faulí Tarazona, Xisco   8
        Budea, Áron             3

* all bugs tagged with 'regression'
    + 774(-5) bugs open of 5774(+21) total 14(+1) high prio.

    + Done by:
        Faulí Tarazona, Xisco  11
        Alex Thurgood           2
        Budea, Áron             2
        Yotam Benshalom         1
        Kevin, Suo              1
        Hosny, Khaled           1

        * ~Component   count net * high severity regressions
           LibreOffice - 4 (+1)
                  Calc - 2 (+2)
                  Base - 2 (+0)
               Impress - 2 (+0)
               Writer  - 2 (-1)
            Extensions - 1 (+0)
        graphics stack – 1 (+0)
        Formula Editor – 0 (-1)
                + http://bit.ly/1HWHb3E

                by OS:
                        + Mac     - 5
                        + All     - 5
                        + Linux   - 2
                        + Windows - 2

        * ~Component   count net * all regressions
                   Calc - 127 (+2)
          Writer: other – 120 (-4)
                Impress - 73 (-3)
           Writer: docx - 67 (+0)
            LibreOffice - 57 (+2)
                     UI - 44 (-1)
         graphics stack - 40 (-1)
            Writer: doc - 38 (+0)
                   Base - 32 (+0)
                Borders – 30 (+0)
                   Draw – 30 (+0)
                Crashes – 28 (-2)
         Writer: filter – 23 (-1)
           Writer: perf – 22 (+1)
       filter / storage – 21 (+0)
                  Chart - 21 (+1)
     print / PDF export - 13 (+0)
                  BASIC - 11 (+0)
             Extensions -  3 (+0)
              framework -  3 (+0)
           Installation -  2 (+0)
                    sdk -  1 (+0)
         Formula Editor -  1 (-1)

             + http://bit.ly/1BUdI8i