Date: prev next · Thread: first prev next last
2017 Archives by date, by thread · List index


Hi,

On 2/19/2017 12:34 PM, David Ostrovsky wrote:

Hm.., what was changed since MSVC 2017 support, is that we are passing
toolset version, see commit message of the change you pointed to, and
particularly this line in external packages make files:

  $(if $(filter
$(UCRTVERSION),),,/p:WindowsTargetPlatformVersion=$(UCRTVERSION)) \

e.g.

https://cgit.freedesktop.org/libreoffice/core/diff/external/lcms2/Exter
nalProject_lcms2.mk?id=b862cbdd345ec57c2595629ded6a3969e1e65d56

So, if your UCRTVERSION is 10.0.10240.0 (can you verify in
config_host.mk?), then the corresponding msbuild toolset must be
installed. Looks like you have only partially installed SDK 10 on your
machine, so you are on your own.

As explained in the commit message, that was needed to force msbuild to
use non default toolset (fro SDK 10) when no default one (SDK 8) is
installed on the system.

Possibly offtopic here, but shouldn't we explicitly use v140_xp toolset with VS 2015 *until* 
there's a need to explicitly drop XP? Answering to possible Tor's reaction ;-) , I want to clarify 
that personally I am all for dropping XP at the very moment we would need a single OS/compiler/... 
feature that we cannot have with it, but not earlier.

--
Best regards,
Mike Kaganski

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.