Hi,
On Tue, Jan 03, 2017 at 07:22:48AM +0100, jan iversen wrote:
It is a matter if taste if you call it a simple list, but adding all header
files present in the module (file listing) would allow the contributor to
edit those.
Hey, you asked for "a simple file list", not me. ;)
Adding an extra project with module "include" allows editing of the public
header files. This is not only important for allowing edit but also if we
want to use a git plugin.
So:
- so gbuild has only a very, very weak concept of a "module"
- our git has no concept of a "module"
- this is both a Good Thing(tm) that we should keep
There only is a _convention_ that the result of:
git ls-tree -r --name-only HEAD <module> | grep -E '.h(|xx)$'
git ls-tree -r --name-only HEAD include/<module>
belongs to <module> in one specific checkout of master. This is a _convention_,
not something that is or ever should be enforced in the build system. Also it
is not something that should be statically generated as adding a file to git is
all it takes to make that file part of the module and thus such a list is
easily outdated[1].
Best,
Bjoern
[1] see also: http://wiki.c2.com/?DontRepeatYourself
http://wiki.c2.com/?OnceAndOnlyOnce
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.