Re: Request For Comments: Hebrew numbering in Libreoffice

Hi Eike,

On 14/12/2016 01:08 AM, Eike Rathke wrote:
> Hi Yossi,
>
> On Tuesday, 2016-12-13 20:41:04 +0100, Eike Rathke wrote:
>
> > Btw, there's a second UI string list in
> > svx/source/dialog/numberingtype.src (new file renamed from
> > svx/source/dialog/pagenumbering.src), so if the Hebrew numbering types
> > are used also in page numbering they likely should go in there as well.
> I added those there and also removed the string definitions from
> cui/uiconfig/ui/numberingoptionspage.ui so that now we have one central
> place where the strings are defined and translated.
>
> > I eliminated yet a third place where UI strings were defined just today,
> > sw/source/ui/misc/numberingtypelistbox.src
> >
> > You may want to update your worktree to current master or at least
> > cherry-pick the related work. Commits in order:
> >
> > 1141f178382be0add06ba182cc02c2adb7e96324
> > b845be872cd3fc6b4dc0e6175675a9b31ef7fc42
> > 97490635ef1b383b8c9759653edb4836015ba6d2
> > a9a5b95de8cf0005476a375b0e4038283f03b818
> Additionally needed:
>
> 3b4712c3969c705edcfc756492da6db7c0d2e018
> 3bd6a8c21ff325b77fb2805158115145edf5ffb5
> 5965a4ae5eacb874102af6c4ebdb5147e1544ef6
> b8ae49a315923eecf11b1186924fbccdae78fe78
>
>    Eike
Have I understood correctly that all necessary changes have been made to 
include NUMBER_HEBREW and the new UI string for CHARS_HEBREW in all 
places where there is a numbering-type list-box?