Hi Yossi, On Tuesday, 2016-12-13 08:22:15 +0200, Yossi Zahn wrote:
On 08/12/2016 07:50 PM, Eike Rathke wrote:The UI visible strings are obtained from cui/uiconfig/ui/numberingoptionspage.uiIt seems that the numbering options that appear in numberingoptionspage.ui will always be higher up in the list than those that are added dynamically in cui/source/tabpages/numpages.cxx. The dynamically added numbering options seem to appear in the order that they are defined in aSupportedTypes[] in defaultnumberingprovider.cxx. I'm wondering if it should be that way?
The not explicitly defined types are currently added to the predefined list, yes, but that could probably be rearranged somehow. Just in what order? My suggestion would be to have the aSupportedTypes[] array in a sensible order and add entries to the UI list in that order while taking the UI visible string from the dialog or resource if defined. Btw, there's a second UI string list in svx/source/dialog/numberingtype.src (new file renamed from svx/source/dialog/pagenumbering.src), so if the Hebrew numbering types are used also in page numbering they likely should go in there as well. I eliminated yet a third place where UI strings were defined just today, sw/source/ui/misc/numberingtypelistbox.src You may want to update your worktree to current master or at least cherry-pick the related work. Commits in order: 1141f178382be0add06ba182cc02c2adb7e96324 b845be872cd3fc6b4dc0e6175675a9b31ef7fc42 97490635ef1b383b8c9759653edb4836015ba6d2 a9a5b95de8cf0005476a375b0e4038283f03b818 Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/ Care about Free Software, support the FSFE https://fsfe.org/support/?erack
Attachment:
signature.asc
Description: PGP signature