Hi Khaled,
Khaled Hosny píše v Pá 25. 11. 2016 v 13:02 +0200:
The thing that the unit test was checking (that RTL_TEXTENCODING_DONTKNOW
is used) caused another bug and IMO was the wrong fix, so keeping the
unit test did not make much sense. Now thinking about it, may be I
should have kept the test and made it check for RTL_TEXTENCODING_SYMBOL
instead, right?
The original issue is now fixed in 37a14c5e359a554195fbcbe2805a284ccf4cb677,
but no unit test there since the fix is now in the font and don’t know
how to test that.
I see - thank you for the explanation & the fixes!
If the fix was in the font, and if we roundtrip the document correctly,
it was probably the right thing to remove the test; sorry for the noise.
Let's see if Miklos has an idea when he's back.
All the best,
Kendy
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.