Hi Tamás, On Monday, 2016-11-21 13:43:18 +0000, Tamás Zolnai wrote:
offapi/com/sun/star/sheet/GeneralFunction.idl | 14 ++++++-------- offapi/type_reference/offapi.idl | 18 +++++++++---------
This is a no-go, already the previous commit eb27a63a38ee7d15292dc40520b0605e4c2228e2 was.. if you have to modify offapi/type_reference/offapi.idl then obviously you're introducing an incompatible change, and the type_reference should *never* be modified, as it exactly checks API against incompatibilites with existing API. In this case extending an enum with a new value, even if appended, may cause problems with existing Java programs, if it receives an unknown enum value it will bail out. Because css::sheet::GeneralFunction is used as readable property, as return value and also as a member in css::sheet::SubTotalColumn that can be returned these changes are not acceptable. Please revert: commit eabfd1b60f8e181e0ef2721e716210390528f4ce Author: Tamás Zolnai <tamas.zolnai@collabora.com> Date: Mon Nov 21 13:57:29 2016 +0000 commit eb27a63a38ee7d15292dc40520b0605e4c2228e2 Author: Tamás Zolnai <zolnaitamas2000@gmail.com> Date: Sat Nov 19 22:27:20 2016 +0100 To introduce new values one has to create a new type, best constant as constant values can be extended, add a new optional property using that type, overriding the old enum, derive a new interface using the type for all interfaces that use GeneralFunction and derive a new struct for SubTotalColumn to also use GeneralFunction. Yes this is painful.. and a reason to never introduce enum types again. For an example see commit 4c4976f717b3ddce68a872dffc2079ae49c41616 Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/ Care about Free Software, support the FSFE https://fsfe.org/support/?erack
Attachment:
signature.asc
Description: PGP signature