Re: [Libreoffice-commits] core.git: 6 commits - offapi/com offapi/type_reference sc/inc sc/qa sc/source

On 11/20/2016 12:43 AM, Tamás Zolnai wrote:
> commit eb27a63a38ee7d15292dc40520b0605e4c2228e2
> Author: Tamás Zolnai <zolnaitamas2000@gmail.com>
> Date:   Sat Nov 19 22:27:20 2016 +0100
>
>     [API Change] PivotMedian: Add median to pivot table function type

Are you sure that this incompatible change is acceptable?  Can you give 
some rationale why that would be so (e.g., this functionality might be 
known to be hardly useful for 3rd party code anyway).

Why did you add the new member in the middle, changing the values of 
many existing members?  Adding it to the end would at least reduce the 
risk of breaking things.

>     Change-Id: I675e81b5c13832ac0ff893a6e080241e6f1c8fd5
>
> diff --git a/offapi/com/sun/star/sheet/GeneralFunction.idl 
> b/offapi/com/sun/star/sheet/GeneralFunction.idl
> index ff9615c..726ae9d 100644
> --- a/offapi/com/sun/star/sheet/GeneralFunction.idl
> +++ b/offapi/com/sun/star/sheet/GeneralFunction.idl
> @@ -56,6 +56,13 @@ published enum GeneralFunction
>      AVERAGE,
>
>
> +    /**
> +    *   median of all numerical values is calculated.
> +    *   @since LibreOffice 5.3
> +    */
> +    MEDIAN,
> +
> +
>      /** maximum value of all numerical values is calculated.
>       */
>      MAX,
> diff --git a/offapi/type_reference/offapi.idl b/offapi/type_reference/offapi.idl
> index 1785f24..b939b24 100644
> --- a/offapi/type_reference/offapi.idl
> +++ b/offapi/type_reference/offapi.idl
> @@ -11484,14 +11484,15 @@ module com {
>       SUM = 2,
>       COUNT = 3,
>       AVERAGE = 4,
> -     MAX = 5,
> -     MIN = 6,
> -     PRODUCT = 7,
> -     COUNTNUMS = 8,
> -     STDEV = 9,
> -     STDEVP = 10,
> -     VAR = 11,
> -     VARP = 12
> +     MEDIAN = 5,
> +     MAX = 6,
> +     MIN = 7,
> +     PRODUCT = 8,
> +     COUNTNUMS = 9,
> +     STDEV = 10,
> +     STDEVP = 11,
> +     VAR = 12,
> +     VARP = 13
>      };
>      /** @deprecated */ published interface XConsolidationDescriptor {
>       interface ::com::sun::star::uno::XInterface;