Re: Calc HYPGEOMDIST: conditionally changing function opcode when saving to Excel format

Hi Winfried,

On Wednesday, 2016-10-05 12:28:04 +0200, Winfried Donkers wrote:

> > > -save in Excel as HYPGEOMDIST in case of 4 arguments and HYPGEOM.DIST in
> > case of 5 arguments.
> > >
> >
> > I think you have this in mind:
> > formula/source/core/api/token.cxx
> > MissingConventionOOXML::isRewriteNeeded()
> > FormulaTokenArray::RewriteMissing()
>
> Thanks, that is the spot to change the function opcode.
> Now I hit the second barrier:
> ODFF allows 4 arguments, but Excel needs 5, so when saving to OOXML, I need to add an argument 
> when that is not given.

I thought that was to be written as HYPGEOMDIST then and not HYPGEOM.DIST?

> I have done that before, somewhere, but predictably I forgot where.
>
> Do you have a hint available here too? ;-)

That would be same file, FormulaMissingContext::AddMoreArgs() for case
MissingConvention::FORMULA_MISSING_CONVENTION_OOXML add a case for the
OpCode and there add ocSep and probably best ocFalse,ocOpen,ocClose.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack

Attachment: signature.asc
Description: PGP signature