Date: prev next · Thread: first prev next last
2016 Archives by date, by thread · List index


Hi Maarten,

On Wednesday, 2016-08-31 10:49:11 +0200, Maarten Bosmans wrote:

What is the correct way to submit a patch series to gerrit? I'd like
to avoid squashing all patches into one commit, but there also has to
be a way for reviewers to see that all patches in a series are
related.

I'm fine with separate changes that depend on another (preferrably if
they're clean and wellformed and can be applied and built as is in order ;-)
Gerrit indicates the relationship through the "Related Changes" list on
the right hand side, but that sometimes can also be misleading.

Adding a short "This depends on https://gerrit.libreoffice.org/<changenumber>"
as gerrit comment / Reply after having submitted the changes is nice for
reviewers.

Having a topic name in the topic field for both changes is also a good
indicator. A topic can be conveniently set already when pushing the
changes to gerrit using the git-review tool: git review -t mytopic
Or plain git: git push gerrit HEAD:refs/for/master/mytopic

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack

Attachment: signature.asc
Description: PGP signature


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.