Date: prev next · Thread: first prev next last
2016 Archives by date, by thread · List index


On 06/27/2016 07:04 PM, Szymon Kłos wrote:
Dnia 2016-06-27, pon o godzinie 15:00 +0200, Stephan Bergmann pisze:
On 06/27/2016 02:47 PM, Szymon Kłos wrote:
+     */
+    long FirstLine;
+
+
+    /** specifies a scale value for the left margin.

as a percentage value?  why have both fixed values and scaling for
these
margins?

also, I wouldn't bother with 'short' and just use 'long' for all
these
values


Yes, as a percentage value. SvxLRSpaceItem stores both fixed values and
scaling so I added this fields too.

Looks a bit odd to me, but I'm anything but a domain expert here, so don't have any idea whether that's good or bad design. Just remember that the entities in the API should make sense from a client's perspective, not necessarily reflect whatever existing implementation design.

Should I change these short types to long and add missing metrics to
the description?

That's what I'd do, yes.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.