Date: prev next · Thread: first prev next last
2016 Archives by date, by thread · List index


On 06/27/2016 02:47 PM, Szymon Kłos wrote:
commit 723467bd88a50323ccd2e4046d0a36332c664a66
Author: Szymon Kłos <eszkadev@gmail.com>
Date:   Tue May 31 16:57:13 2016 +0200

    [API CHANGE] notebookbar: paragraph spacing controls

Is this an incompatible change? (Otherwise, it shouldn't be labelled "[API CHANGE]".)


    Change-Id: I9d2672cd156f2dcc2ee4c544902e9d42632cab70
    Reviewed-on: https://gerrit.libreoffice.org/26039
    Tested-by: Jenkins <ci@libreoffice.org>
    Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

[...]
diff --git a/offapi/com/sun/star/frame/status/LeftRightMarginScale.idl 
b/offapi/com/sun/star/frame/status/LeftRightMarginScale.idl
new file mode 100644
index 0000000..b5f66e2
--- /dev/null
+++ b/offapi/com/sun/star/frame/status/LeftRightMarginScale.idl
@@ -0,0 +1,78 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ *   Licensed to the Apache Software Foundation (ASF) under one or more
+ *   contributor license agreements. See the NOTICE file distributed
+ *   with this work for additional information regarding copyright
+ *   ownership. The ASF licenses this file to you under the Apache
+ *   License, Version 2.0 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+#ifndef __com_sun_star_frame_status_LeftRightMarginScale_idl__
+#define __com_sun_star_frame_status_LeftRightMarginScale_idl__
+
+
+
+module com {  module sun {  module star {  module frame {  module status {
+
+
+/** specifies a left and right margin.
+
+    @since LibreOffice 5.3
+ */
+struct LeftRightMarginScale
+{
+    /** specifies a left text margin in 1/100th mm.
+     */
+    long TextLeft;
+
+
+    /** specifies a left margin in 1/100th mm.
+     */
+    long Left;
+
+
+    /** specifies a right margin in 1/100th mm.
+     */
+    long Right;
+
+
+     /** specifies a first line indent relative to TextLeft.

also in 1/100th mm?

+     */
+    long FirstLine;
+
+
+    /** specifies a scale value for the left margin.

as a percentage value? why have both fixed values and scaling for these margins?

also, I wouldn't bother with 'short' and just use 'long' for all these values

+     */
+    short ScaleLeft;
+
+
+    /** specifies a scale value for the right margin.
+     */
+    short ScaleRight;
+
+
+    /** specifies a scale value for the first line margin.
+     */
+    short ScaleFirstLine;
+
+
+    /** specifies if the automatic calculation of the first line indent occurs.
+    */
+    boolean AutoFirstLine;
+};
+
+
+}; }; }; }; };
+
+#endif
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[...]

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.