Re: CppCheck Report Update

Hi,


Ive taken the liberty of changing the crontab entry for the creation of the
cppcheck report on vm140 from this :

/home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s
/home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w
/home/buildslave/tmp/www >/tmp/cppcheck-report.log 2>&1

to this :

cd /home/buildslave/source/dev-tools && git pull &&
/home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s
/home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck -w
/home/buildslave/tmp/www >/tmp/cppcheck-report.log 2>&1

in order to make any future updates to the script automatically be used by
means of a git pull of the corresponding dev-tools repo before running the
script. Ive tested this on a local vm with the same Linux distro (Mageia
4), and it seems to work.


By the way, searching through the mailing list archives it seems that the
emails to the list reporting the success or failure of the
cppcheck-report.sh run have stopped.

Trying out the command (sendEmail) used (with the addition of '-vv') from
the commandline on the vm, I get the following error :


Jun 23 17:49:30 vm140 sendEmail[2910]: DEBUG => Connecting to
smtp.gmail.com:587
Jun 23 17:49:30 vm140 sendEmail[2910]: DEBUG => My IP address is:
89.238.68.140
Jun 23 17:49:30 vm140 sendEmail[2910]: DEBUG => evalSMTPresponse() - Found
SMTP success code: 220
Jun 23 17:49:30 vm140 sendEmail[2910]: SUCCESS => Received:     220
smtp.gmail.com ESMTP x194sm4488242wmf.13 - gsmtp
Jun 23 17:49:30 vm140 sendEmail[2910]: INFO => Sending:         EHLO
vm140.documentfoundation.org
Jun 23 17:49:30 vm140 sendEmail[2910]: DEBUG => evalSMTPresponse() - Found
SMTP success code: 250
Jun 23 17:49:30 vm140 sendEmail[2910]: SUCCESS => Received:
250-smtp.gmail.com at your service, [89.238.68.140], 250-SIZE 35882577,
250-8BITMIME, 250-STARTTLS, 250-ENHANCEDSTATUSCODES, 250-PIPELINING,
250-CHUNKING, 250 SMTPUTF8
Jun 23 17:49:30 vm140 sendEmail[2910]: DEBUG => The remote SMTP server
supports TLS :)
Jun 23 17:49:30 vm140 sendEmail[2910]: DEBUG => Starting TLS
Jun 23 17:49:30 vm140 sendEmail[2910]: INFO => Sending:         STARTTLS
Jun 23 17:49:30 vm140 sendEmail[2910]: DEBUG => evalSMTPresponse() - Found
SMTP success code: 220
Jun 23 17:49:30 vm140 sendEmail[2910]: SUCCESS => Received:     220 2.0.0
Ready to start TLS
Jun 23 17:49:30 vm140 sendEmail[2910]: ERROR => TLS setup failed: SSL
connect attempt failed because of handshake problems error:1409442E:SSL
routines:SSL3_READ_BYTES:tlsv1 alert protocol version


I googled the (last line) error, and this page [1] seems to suggest to
install different/better/more maintained/updated perl modules, and then
update the sendEmail perl script (which was last updated in 2009) to use
those perl modules.

So as far as I can see, *if* receiving failed/succeeded email messages is
still wanted, there are the following options :


A.)
modify the sendEmail perl script and use different more recent perl
modules. I have absolutely zero perl skills, so someone else would have to
spend some time to update the script in this scenario.

B.)
drop sendEmail, install mail/mailx and install&configure something like
sendmail/postfix/exim on vm140 and see if the cppcheck-report.sh script can
be modified to use mail/mailx instead. I do have some shell skills, so I
could spend some time on that myself to see if I can make that work. But I
will need some help with the sendmail/postfix/exim configuration part. (and
I guess if vm140 cannot receive mail, then the account used to send the
email would need to be approved for sending to the mailing list in some
other manner than 'the normal way').

C.)
leave it 'as-is': receiving email fail/succeed notifications isnt really
considered important enough.



- Maarten



[1]
https://stackoverflow.com/questions/37277583/send-mail-through-gmail-using-perl






On Sun, Jun 12, 2016 at 3:04 PM, Maarten Hoes <hoes.maarten@gmail.com>
wrote:

> Caolán McNamara wrote
> > On Sun, 2016-02-28 at 01:35 +0000,
>
> > cppcheck.libreoffice@
>
> > > > Note:
> > > >     The script generating this report was run at :
> > > >         2016-28-02_02:35:42 with user buildslave at host vm140 as
> > > > /home/buildslave/source/dev-tools/cppcheck/cppcheck-report.sh -s
> > > > /home/buildslave/source/libo-core -c /home/buildslave/source/cppcheck
> > > > -w /home/buildslave/tmp/www
> > > >
> > > >     It can be found and improved here:
> > > >         https://gerrit.libreoffice.org/gitweb?p=dev-
> > > > tools.git;a=blob;f=cppcheck/cppcheck-report.sh
> >
> > > cppcheck-report.sh (since Feb 15) has --inline-suppr enabled in it so I
> > > would have expected http://dev-builds.libreoffice.org/cppcheck_reports/
> > > master/382.html#line-240 not to appear.
> >
> > > Is that inline suppression markup wrong. Or does something need to be
> > > done to refresh from git the cppcheck-report.sh used to build these
> > > reports ?
> >
> > Hi,
> >
> >
> > A little late, and really only by accident that I ran into your post, but
> > ...
> >
> >
> > The git version of 'cppcheck-report.sh' seems indeed to have been updated
> > on 2016-02-15 by you to include the '--inline-suppr' you mentioned.
> > However, 'for reasons', the (git) version of the script that is located
> on
> > vm140.documentfoundation.org isnt updated by 'git pull' on a regular
> > basis. (I guess a cron job or something similar could be used to update
> > the repo on a regular basis). So the older version was still used for
> > creating the report.
> >
> > I just logged into vm140 (I still seems to have ssh-key access, which may
> > or may not be what was intended) and did a 'git pull' for you, updating
> > the repo to the latest version of 'cppcheck-report.sh', so the next run
> > should include your changes.
> >
> > Hope this helps and I didnt inadvertently mess something up.
> >
> >
> > - Maarten
> >
> >
> >
> >
> >
> >
> > C.
> > _______________________________________________
> > LibreOffice mailing list
>
> > LibreOffice@.freedesktop
>
> > https://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>
>
>
>
> --
> View this message in context:
> http://nabble.documentfoundation.org/CppCheck-Report-Update-tp4176815p4185951.html
> Sent from the Dev mailing list archive at Nabble.com.
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice