On 21 Jun 2016, at 13:03, Christian Lohmaier <lohmaier@googlemail.com> wrote:
On Sun, Jun 19, 2016 at 9:07 AM, jan iversen
<jani@documentfoundation.org> wrote:
As a new committer (thanks again for your confidence), I don't know yet all
the rules and I prefer to ask before breaking something.
Asking is clearly better than breaking :-)
As it is for 5-2 branch, do they require review from someone else than me,
before they can be pushed? (commits were already reviewed for master by jan)
Our review rules are described here (and how to add a patch to a branch):
https://wiki.documentfoundation.org/Development/Branches
Your patches are fixes to a X-Y branch, so no further review required.
Only in beta phase does a x-y branch not require review. after that it
needs one review.
Maybe the text should be corrected in our wiki:
No review required until the last beta
which I read as no extra review is needed for a X-Y branch.
And as Stephan pointed out: Only bugfixes go in.
And since this is a bugfix it should not be a problem ?
rgds
jan I.
ciao
Christian
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.