Hi
As a new committer (thanks again for your confidence), I don't know yet all
the rules and I prefer to ask before breaking something.
Asking is clearly better than breaking :-)
As it is for 5-2 branch, do they require review from someone else than me,
before they can be pushed? (commits were already reviewed for master by jan)
Our review rules are described here (and how to add a patch to a branch):
https://wiki.documentfoundation.org/Development/Branches
Your patches are fixes to a X-Y branch, so no further review required.
Letting the patch linger a couple of days in gerrit is not a demand, but gives others a chance to
comment, therefore highly recommended.
Your patches has been lingering, so go ahead and do your first merge,
Thanks for your help.
Thanks for your work.
rgds
jan i
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.